From 445a58a81996b6e9983299bc77a5e239b0c5db83 Mon Sep 17 00:00:00 2001
From: Daniel Seifert <git@daniel-seifert.com>
Date: Mon, 13 May 2024 16:24:34 +0200
Subject: [PATCH] add ViewId tests

---
 Application/Controller/Admin/d3ActionWizard.php   |  3 ++-
 Application/Controller/Admin/d3ExportWizard.php   |  2 +-
 .../Controller/Admin/d3AdminController.php        | 15 +++++++++++++++
 .../Controller/Admin/d3ExportWizardTest.php       |  3 ---
 4 files changed, 18 insertions(+), 5 deletions(-)

diff --git a/Application/Controller/Admin/d3ActionWizard.php b/Application/Controller/Admin/d3ActionWizard.php
index 2769f60..e9a4a63 100644
--- a/Application/Controller/Admin/d3ActionWizard.php
+++ b/Application/Controller/Admin/d3ActionWizard.php
@@ -44,10 +44,11 @@ class d3ActionWizard extends AdminDetailsController
         $this->configuration = oxNew(Configuration::class);
     }
 
-    public function getViewId()
+    public function getViewId(): string
     {
         return 'd3mxDataWizard_Action';
     }
+
     public function getGroups(): array
     {
         return $this->configuration->getActionGroups();
diff --git a/Application/Controller/Admin/d3ExportWizard.php b/Application/Controller/Admin/d3ExportWizard.php
index cb56926..562349e 100644
--- a/Application/Controller/Admin/d3ExportWizard.php
+++ b/Application/Controller/Admin/d3ExportWizard.php
@@ -49,7 +49,7 @@ class d3ExportWizard extends AdminDetailsController
         $this->configuration = oxNew(Configuration::class);
     }
 
-    public function getViewId()
+    public function getViewId(): string
     {
         return 'd3mxDataWizard_Export';
     }
diff --git a/tests/unit/Application/Controller/Admin/d3AdminController.php b/tests/unit/Application/Controller/Admin/d3AdminController.php
index 63ff3d5..afc15e4 100644
--- a/tests/unit/Application/Controller/Admin/d3AdminController.php
+++ b/tests/unit/Application/Controller/Admin/d3AdminController.php
@@ -72,6 +72,21 @@ abstract class d3AdminController extends d3ModCfgUnitTestCase
         );
     }
 
+    /**
+     * @test
+     * @return void
+     * @throws ReflectionException
+     * @covers \D3\DataWizard\Application\Controller\Admin\d3ActionWizard::getViewId
+     * @covers \D3\DataWizard\Application\Controller\Admin\d3ExportWizard::getViewId
+     */
+    public function canGetViewId(): void
+    {
+        $viewId = $this->callMethod($this->_oController, 'getViewId');
+
+        $this->assertIsString($viewId);
+        $this->assertStringStartsWith('d3mxDataWizard', $viewId);
+    }
+
     /**
      * @covers \D3\DataWizard\Application\Controller\Admin\d3ActionWizard::runTask()
      * @covers \D3\DataWizard\Application\Controller\Admin\d3ExportWizard::runTask()
diff --git a/tests/unit/Application/Controller/Admin/d3ExportWizardTest.php b/tests/unit/Application/Controller/Admin/d3ExportWizardTest.php
index a09205b..5d5bce4 100644
--- a/tests/unit/Application/Controller/Admin/d3ExportWizardTest.php
+++ b/tests/unit/Application/Controller/Admin/d3ExportWizardTest.php
@@ -24,7 +24,6 @@ use D3\DataWizard\Application\Model\ExportRenderer\RendererBridge;
 use D3\DataWizard\tests\tools\d3TestAction;
 use D3\DataWizard\tests\tools\d3TestExport;
 use Doctrine\DBAL\Exception as DBALException;
-use OxidEsales\Eshop\Core\Config;
 use OxidEsales\Eshop\Core\Exception\DatabaseErrorException;
 use OxidEsales\Eshop\Core\Registry;
 use OxidEsales\Eshop\Core\Request;
@@ -193,8 +192,6 @@ class d3ExportWizardTest extends d3AdminController
         ];
     }
 
-
-
     /**
      * @return string[][]
      */