From b7167ec60a13288ec7428f6aaaeb3dc70e523530 Mon Sep 17 00:00:00 2001 From: MaxBUhe Date: Tue, 4 Jun 2024 12:09:29 +0200 Subject: [PATCH] [Fixed] missing return statements, on null --- Application/Model/ManagerHandler.php | 4 +++- Modules/Core/ViewConfig.php | 8 ++++---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/Application/Model/ManagerHandler.php b/Application/Model/ManagerHandler.php index e5b7c18..3bb71ca 100644 --- a/Application/Model/ManagerHandler.php +++ b/Application/Model/ManagerHandler.php @@ -32,6 +32,8 @@ class ManagerHandler return $shopModuleId; } } + + return ""; } /** @@ -53,7 +55,7 @@ class ManagerHandler */ public function getModuleSettingExplicitManagerSelectValue() :string { - return Registry::get(ViewConfig::class)->d3GetModuleConfigParam('_HAS_STD_MANAGER'); + return Registry::get(ViewConfig::class)->d3GetModuleConfigParam('_HAS_STD_MANAGER')?:""; } /** diff --git a/Modules/Core/ViewConfig.php b/Modules/Core/ViewConfig.php index 152b0f2..ac7b754 100644 --- a/Modules/Core/ViewConfig.php +++ b/Modules/Core/ViewConfig.php @@ -173,7 +173,7 @@ class ViewConfig extends ViewConfig_parent public function isGtmConsentModeSetActivated() :bool { - return $this->d3GetModuleConfigParam("_blEnableConsentMode"); + return $this->d3GetModuleConfigParam("_blEnableConsentMode")?: false; } public function getGtmDataLayer() @@ -215,7 +215,7 @@ class ViewConfig extends ViewConfig_parent public function isDebugModeOn() :bool { - return $this->d3GetModuleConfigParam("_blEnableDebug"); + return $this->d3GetModuleConfigParam("_blEnableDebug")?: false; } /** @@ -225,7 +225,7 @@ class ViewConfig extends ViewConfig_parent */ public function getServerSidetaggingJsDomain() :string { - return $this->d3GetModuleConfigParam("_sServersidetagging_js"); + return $this->d3GetModuleConfigParam("_sServersidetagging_js")?: ""; } /** @@ -235,7 +235,7 @@ class ViewConfig extends ViewConfig_parent */ public function getServerSidetaggingNoJsDomain() :string { - return $this->d3GetModuleConfigParam('_sServersidetagging_nojs'); + return $this->d3GetModuleConfigParam('_sServersidetagging_nojs')?: ""; } /**