From bb513e6dedc6bd3830e0da923bf96ce92026eba5 Mon Sep 17 00:00:00 2001 From: MaxBUhe Date: Wed, 13 Sep 2023 15:13:35 +0200 Subject: [PATCH] adjust set-param check --- Modules/Core/ViewConfig.php | 10 +++------- metadata.php | 2 +- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/Modules/Core/ViewConfig.php b/Modules/Core/ViewConfig.php index 39e1818..e5af0db 100644 --- a/Modules/Core/ViewConfig.php +++ b/Modules/Core/ViewConfig.php @@ -121,7 +121,7 @@ class ViewConfig extends ViewConfig_parent { $sControlParameter = trim(Registry::getConfig()->getConfigParam('d3_gtm_settings_controlParameter')); - if (false === $this->shallUseOwnCookieManager()){ + if (false === $this->shallUseOwnCookieManager() or ($sControlParameter === '')){ return ""; } @@ -130,16 +130,12 @@ class ViewConfig extends ViewConfig_parent or $this->sCookieManagerType === ManagerTypes::USERCENTRICS_MANUALLY ) { - if ($sControlParameter) { - return 'data-usercentrics="' . $sControlParameter . '" type="text/plain" async=""'; - } + return 'data-usercentrics="' . $sControlParameter . '" type="text/plain" async=""'; } if ($this->sCookieManagerType === ManagerTypes::CONSENTMANAGER) { - if ($sControlParameter) { - return 'type="text/plain" class="cmplazyload" data-cmp-vendor="'.$sControlParameter.'"'; - } + return 'type="text/plain" class="cmplazyload" data-cmp-vendor="'.$sControlParameter.'"'; } if ($this->sCookieManagerType === ManagerTypes::COOKIEFIRST){ diff --git a/metadata.php b/metadata.php index 2040610..e6b1fa5 100755 --- a/metadata.php +++ b/metadata.php @@ -133,7 +133,7 @@ $aModule = [ 'group' => 'd3_gtm_settings_cookiemanager', 'name' => 'd3_gtm_settings_controlParameter', 'type' => 'str', - 'value' => 'example', + 'value' => '', 'position' => 999 ], [