D3Public/GoogleAnalytics4
8
0
Fork 0
Code Pull Requests Packages Projects Releases Activity

[Changed] remove save-logic from Getter-Method

Browse Source
This commit is contained in:
MaxBuhe01 2025-03-19 08:31:56 +01:00
parent 3250f2bf91
commit e347739bd3
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Application/Controller/Admin/GA4AdminUserInterface_main.php
View File

@ -21,7 +21,12 @@ class GA4AdminUserInterface_main extends \OxidEsales\Eshop\Application\Controlle
$this->addTplParam('d3ViewObject', $this); $this->addTplParam('d3ViewObject', $this);
$this->addTplParam('d3ViewConfObject', Registry::get(ViewConfig::class)); $this->addTplParam('d3ViewConfObject', Registry::get(ViewConfig::class));
$this->addTplParam('d3ManagerTypeArray', oxNew(ManagerTypes::class)->getManagerList()); $this->addTplParam('d3ManagerTypeArray', oxNew(ManagerTypes::class)->getManagerList());
$this->addTplParam('d3CurrentCMP', oxNew(ManagerHandler::class)->getCurrManager());
$sActManager = oxNew(ManagerHandler::class)->getCurrManager();
$this->addTplParam('d3CurrentCMP', $sActManager);
//Todo: hier ein Test, ist es denn nötig IMMER, meinen Wert zu speichern? Eigentlich doch nur, wenn ich im Admin auf speichern klicke!
//oxNew(ManagerHandler::class)->d3SaveShopConfVar($sActManager);
return $return; return $return;
} }

13
Application/Model/ManagerHandler.php
View File

@ -14,21 +14,18 @@ class ManagerHandler
*/ */
public function getCurrManager() :string public function getCurrManager() :string
{ {
if ($this->getModuleSettingExplicitManagerSelectValue()){
return $this->getExplicitManager();
}
/** @var ManagerTypes $oManagerTypes */ /** @var ManagerTypes $oManagerTypes */
$oManagerTypes = oxNew(ManagerTypes::class); $oManagerTypes = oxNew(ManagerTypes::class);
/** @var ViewConfig $oViewConfig */ /** @var ViewConfig $oViewConfig */
$oViewConfig = oxNew(ViewConfig::class); $oViewConfig = oxNew(ViewConfig::class);
$aManagerList = $oManagerTypes->getManagerList(); $aManagerList = $oManagerTypes->getManagerList();
if ($this->getModuleSettingExplicitManagerSelectValue()){
return $this->getExplicitManager();
}
foreach ($aManagerList as $shopModuleId => $publicCMPName){ foreach ($aManagerList as $shopModuleId => $publicCMPName){
if ($oViewConfig->isModuleActive($shopModuleId)){ if ($oViewConfig->isModuleActive($shopModuleId)){
$this->d3SaveShopConfVar($shopModuleId);
return $shopModuleId; return $shopModuleId;
} }
} }
@ -71,8 +68,6 @@ class ManagerHandler
? $sPotentialManagerName ? $sPotentialManagerName
: "NONE"; : "NONE";
$this->d3SaveShopConfVar($sCMPName);
return $sCMPName; return $sCMPName;
} }
} }