Compare commits

...

2 Commits

Author SHA1 Message Date
97dad5c8eb [Bump] Metadata && Changelog 2024-06-04 12:10:47 +02:00
b7167ec60a [Fixed] missing return statements, on null 2024-06-04 12:09:29 +02:00
4 changed files with 12 additions and 6 deletions

View File

@ -32,6 +32,8 @@ class ManagerHandler
return $shopModuleId; return $shopModuleId;
} }
} }
return "";
} }
/** /**
@ -53,7 +55,7 @@ class ManagerHandler
*/ */
public function getModuleSettingExplicitManagerSelectValue() :string public function getModuleSettingExplicitManagerSelectValue() :string
{ {
return Registry::get(ViewConfig::class)->d3GetModuleConfigParam('_HAS_STD_MANAGER'); return Registry::get(ViewConfig::class)->d3GetModuleConfigParam('_HAS_STD_MANAGER')?:"";
} }
/** /**

View File

@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [unreleased](https://git.d3data.de/D3Public/GoogleAnalytics4/compare/2.17.2...rel_2.x) - 2024-x ## [unreleased](https://git.d3data.de/D3Public/GoogleAnalytics4/compare/2.17.2...rel_2.x) - 2024-x
## [2.18.1](https://git.d3data.de/D3Public/GoogleAnalytics4/compare/2.18.0...2.18.1) - 2024-06-04
### Fixed
- missing return statement, on null/ none
## [2.18.0](https://git.d3data.de/D3Public/GoogleAnalytics4/compare/2.17.2...2.18.0) - 2024-06-03 ## [2.18.0](https://git.d3data.de/D3Public/GoogleAnalytics4/compare/2.17.2...2.18.0) - 2024-06-03
### Added ### Added
- trait for generalized method - trait for generalized method

View File

@ -173,7 +173,7 @@ class ViewConfig extends ViewConfig_parent
public function isGtmConsentModeSetActivated() :bool public function isGtmConsentModeSetActivated() :bool
{ {
return $this->d3GetModuleConfigParam("_blEnableConsentMode"); return $this->d3GetModuleConfigParam("_blEnableConsentMode")?: false;
} }
public function getGtmDataLayer() public function getGtmDataLayer()
@ -215,7 +215,7 @@ class ViewConfig extends ViewConfig_parent
public function isDebugModeOn() :bool public function isDebugModeOn() :bool
{ {
return $this->d3GetModuleConfigParam("_blEnableDebug"); return $this->d3GetModuleConfigParam("_blEnableDebug")?: false;
} }
/** /**
@ -225,7 +225,7 @@ class ViewConfig extends ViewConfig_parent
*/ */
public function getServerSidetaggingJsDomain() :string public function getServerSidetaggingJsDomain() :string
{ {
return $this->d3GetModuleConfigParam("_sServersidetagging_js"); return $this->d3GetModuleConfigParam("_sServersidetagging_js")?: "";
} }
/** /**
@ -235,7 +235,7 @@ class ViewConfig extends ViewConfig_parent
*/ */
public function getServerSidetaggingNoJsDomain() :string public function getServerSidetaggingNoJsDomain() :string
{ {
return $this->d3GetModuleConfigParam('_sServersidetagging_nojs'); return $this->d3GetModuleConfigParam('_sServersidetagging_nojs')?: "";
} }
/** /**

View File

@ -50,7 +50,7 @@ $aModule = [
Die Entwicklung basiert auf einem Fork von Marat Bedoev - <a href='https://github.com/vanilla-thunder/oxid-module-gtm'>Github-Link</a> Die Entwicklung basiert auf einem Fork von Marat Bedoev - <a href='https://github.com/vanilla-thunder/oxid-module-gtm'>Github-Link</a>
", ",
'thumbnail' => 'thumbnail.png', 'thumbnail' => 'thumbnail.png',
'version' => '2.18.0', 'version' => '2.18.1',
'author' => 'Data Development (Inh.: Thomas Dartsch)', 'author' => 'Data Development (Inh.: Thomas Dartsch)',
'email' => 'support@shopmodule.com', 'email' => 'support@shopmodule.com',
'url' => 'https://www.oxidmodule.com/', 'url' => 'https://www.oxidmodule.com/',