Compare commits
No commits in common. "2.18.2" and "2.18.1" have entirely different histories.
@ -6,10 +6,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
|
|||||||
|
|
||||||
## [unreleased](https://git.d3data.de/D3Public/GoogleAnalytics4/compare/2.17.2...rel_2.x) - 2024-x
|
## [unreleased](https://git.d3data.de/D3Public/GoogleAnalytics4/compare/2.17.2...rel_2.x) - 2024-x
|
||||||
|
|
||||||
## [2.18.2](https://git.d3data.de/D3Public/GoogleAnalytics4/compare/2.18.0...2.18.1) - 2024-06-25
|
|
||||||
### Fixed
|
|
||||||
- oe-console apply-configuration triggers on-activate and overwrites existing values
|
|
||||||
|
|
||||||
## [2.18.1](https://git.d3data.de/D3Public/GoogleAnalytics4/compare/2.18.0...2.18.1) - 2024-06-04
|
## [2.18.1](https://git.d3data.de/D3Public/GoogleAnalytics4/compare/2.18.0...2.18.1) - 2024-06-04
|
||||||
### Fixed
|
### Fixed
|
||||||
- missing return statement, on null/ none
|
- missing return statement, on null/ none
|
||||||
|
@ -7,7 +7,6 @@ namespace D3\GoogleAnalytics4\Setup;
|
|||||||
|
|
||||||
use D3\GoogleAnalytics4\Application\Model\Constants;
|
use D3\GoogleAnalytics4\Application\Model\Constants;
|
||||||
use OxidEsales\Eshop\Core\Registry;
|
use OxidEsales\Eshop\Core\Registry;
|
||||||
use OxidEsales\Eshop\Core\ViewConfig;
|
|
||||||
|
|
||||||
class Actions
|
class Actions
|
||||||
{
|
{
|
||||||
@ -20,10 +19,6 @@ class Actions
|
|||||||
public function d3SaveDefaultSettings(string $sVarType, string $sSettingName, string $sSettingValue){
|
public function d3SaveDefaultSettings(string $sVarType, string $sSettingName, string $sSettingValue){
|
||||||
$oConfig = Registry::getConfig();
|
$oConfig = Registry::getConfig();
|
||||||
|
|
||||||
if (trim($this->d3GetModuleConfigParam($sSettingName)) !== trim($sSettingValue)){
|
|
||||||
$sSettingValue = trim($this->d3GetModuleConfigParam($sSettingName));
|
|
||||||
}
|
|
||||||
|
|
||||||
$oConfig->saveShopConfVar(
|
$oConfig->saveShopConfVar(
|
||||||
$sVarType,
|
$sVarType,
|
||||||
Constants::OXID_MODULE_ID.$sSettingName,
|
Constants::OXID_MODULE_ID.$sSettingName,
|
||||||
@ -32,13 +27,4 @@ class Actions
|
|||||||
Constants::OXID_MODULE_ID
|
Constants::OXID_MODULE_ID
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
|
||||||
* @param string $configParamName
|
|
||||||
* @return mixed
|
|
||||||
*/
|
|
||||||
public function d3GetModuleConfigParam(string $configParamName)
|
|
||||||
{
|
|
||||||
return Registry::get(ViewConfig::class)->d3GetModuleConfigParam($configParamName);
|
|
||||||
}
|
|
||||||
}
|
}
|
@ -50,7 +50,7 @@ $aModule = [
|
|||||||
Die Entwicklung basiert auf einem Fork von Marat Bedoev - <a href='https://github.com/vanilla-thunder/oxid-module-gtm'>Github-Link</a>
|
Die Entwicklung basiert auf einem Fork von Marat Bedoev - <a href='https://github.com/vanilla-thunder/oxid-module-gtm'>Github-Link</a>
|
||||||
",
|
",
|
||||||
'thumbnail' => 'thumbnail.png',
|
'thumbnail' => 'thumbnail.png',
|
||||||
'version' => '2.18.2',
|
'version' => '2.18.1',
|
||||||
'author' => 'Data Development (Inh.: Thomas Dartsch)',
|
'author' => 'Data Development (Inh.: Thomas Dartsch)',
|
||||||
'email' => 'support@shopmodule.com',
|
'email' => 'support@shopmodule.com',
|
||||||
'url' => 'https://www.oxidmodule.com/',
|
'url' => 'https://www.oxidmodule.com/',
|
||||||
|
Loading…
x
Reference in New Issue
Block a user