From 7deab9c67f3ae887d49194897d99329bc22c07cf Mon Sep 17 00:00:00 2001
From: Daniel Seifert <git@daniel-seifert.com>
Date: Thu, 31 Oct 2024 21:21:54 +0100
Subject: [PATCH] extract helper functions

---
 recipe/inc/database.php | 19 +++++++++++++++++++
 recipe/shopTasks.php    | 18 +++++-------------
 2 files changed, 24 insertions(+), 13 deletions(-)
 create mode 100644 recipe/inc/database.php

diff --git a/recipe/inc/database.php b/recipe/inc/database.php
new file mode 100644
index 0000000..a81a6a9
--- /dev/null
+++ b/recipe/inc/database.php
@@ -0,0 +1,19 @@
+<?php
+
+namespace Deployer;
+
+set('database_configured', function() {
+    return has('db_name') && strlen(get('db_name')) &&
+        has('db_conf_path') && strlen(get('db_conf_path')) && test("[ -f {{db_conf_path}} ]");
+});
+
+set('mysql_configured', function() {
+    return has('bin/mysql') && strlen(get('bin/mysql')) &&
+        get('database_configured');
+});
+
+set('mysqldump_configured', function() {
+    return has('bin/mysql') && strlen(get('bin/mysql')) &&
+        get('database_configured');
+});
+
diff --git a/recipe/shopTasks.php b/recipe/shopTasks.php
index f13c0d0..732524b 100644
--- a/recipe/shopTasks.php
+++ b/recipe/shopTasks.php
@@ -9,12 +9,11 @@ task('shop:runMigration', [
     'shop:setShopsOnline'
 ]);
 
+require_once 'inc/database.php';
+
 desc('set shops offline');
 task('shop:setShopsOffline', function() {
-    if (has('bin/mysql') && strlen(get('bin/mysql')) &&
-        has('db_name') && strlen(get('db_name')) &&
-        has('db_conf_path') && strlen(get('db_conf_path')) && test("[ -f {{db_conf_path}} ]")
-    ) {
+    if (get('mysql_configured')) {
         $query = "UPDATE oxshops SET oxactive = '0', OXREGISTERSUBJECT = CONCAT('..', OXREGISTERSUBJECT) WHERE oxactive = '1';";
         run('{{bin/mysql}} --defaults-extra-file={{db_conf_path}} {{db_name}} -e "'.$query.'"');
     } else {
@@ -37,10 +36,7 @@ task('shop:executeMigrations', function () {
 
 desc('set shops online');
 task('shop:setShopsOnline', function() {
-    if (has('bin/mysql') && strlen(get('bin/mysql')) &&
-        has('db_name') && strlen(get('db_name')) &&
-        has('db_conf_path') && strlen(get('db_conf_path')) && test("[ -f {{db_conf_path}} ]")
-    ) {
+    if (get('mysql_configured')) {
         $query = "UPDATE oxshops SET oxactive = '1', OXREGISTERSUBJECT = SUBSTR(OXREGISTERSUBJECT, 3) WHERE oxactive = '0' AND OXREGISTERSUBJECT LIKE '..%';";
         run('{{bin/mysql}} --defaults-extra-file={{db_conf_path}} {{db_name}} -e "'.$query.'"');
     } else {
@@ -62,11 +58,7 @@ task('shop:getVersion', function () {
 
 desc('dump contents from source to destination database');
 task('shop:cloneDatabase', function () {
-    if (has('bin/mysql') && strlen(get('bin/mysql')) &&
-        has('bin/mysqldump') && strlen(get('bin/mysqldump')) &&
-        has('db_name') && strlen(get('db_name')) &&
-        has('db_conf_path') && strlen(get('db_conf_path')) && test("[ -f {{db_conf_path}} ]")
-    ) {
+    if (get('mysql_configured') && get('mysqldump_configured')) {
         info('Note: Use a dedicated read only user for accessing the source database.');
         info('Using the following source database:');
         $source_host = ask('source database host', 'localhost');