More cleanup

libs/Format/Confluence/Api.php

@@ -269,7 +269,7 @@ class Api
         }
     }
 
-    private function putAttachment($url, $id, $attachment)
+    private function putAttachment($url, $attachment)
     {
         $contents = array_key_exists('file', $attachment) ? fopen($attachment['file']->getPath(), 'r') : $attachment['content'];
 
@@ -322,6 +322,6 @@ class Api
             $url .= "/{$result['results'][0]['id']}/data";
         }
 
-        $this->putAttachment($url, $id, $attachment);
+        $this->putAttachment($url, $attachment);
     }
 }

libs/Format/Confluence/ContentPage.php

@@ -28,6 +28,8 @@ class ContentPage extends \Todaymade\Daux\Format\Base\ContentPage
                     } else if ($file instanceof ComputedRaw) {
                         $filename = $file->getUri();
                         $this->attachments[$filename] = ['filename' => $filename, 'content' => $file->getContent()];
+                    } else {
+                        throw new \RuntimeException("Cannot embed image as we don't understand its type.");
                     }
 
                     return $this->createImageTag($filename, $attributes);

libs/Format/Confluence/Publisher.php

@@ -36,8 +36,6 @@ class Publisher
 
         $this->client = new Api($confluence['base_url'], $confluence['user'], $confluence['pass']);
         $this->client->setSpace($confluence['space_id']);
-
-        $this->deletable = [];
     }
 
     public function run($title, $closure)
@@ -82,7 +80,6 @@ class Publisher
     {
         if (array_key_exists('ancestor_id', $this->confluence)) {
             $pages = $this->client->getList($this->confluence['ancestor_id']);
-            $published = null;
             foreach ($pages as $page) {
                 if ($page['title'] == $tree['title']) {
                     return $page;

libs/Format/Confluence/PublisherDelete.php

@@ -27,6 +27,9 @@ class PublisherDelete
         $this->output = $output;
         $this->delete = $delete;
         $this->client = $client;
+
+
+        $this->deletable = [];
     }
 
     protected function listDeletable($published, $prefix = '')