From 4e5147a0ac22a337cfcbe2768f6656efde1978a2 Mon Sep 17 00:00:00 2001 From: Daniel Seifert Date: Fri, 15 Jul 2022 23:54:52 +0200 Subject: [PATCH] use generated example phone number --- Tests/RecipientsList/RecipientsListTest.php | 7 ++++++- Tests/Request/AbstractRequest.php | 15 +++++++++++++-- Tests/ValueObject/RecipientTest.php | 8 +++++++- Tests/ValueObject/SenderTest.php | 10 +++++++++- 4 files changed, 35 insertions(+), 5 deletions(-) diff --git a/Tests/RecipientsList/RecipientsListTest.php b/Tests/RecipientsList/RecipientsListTest.php index fce2358..8bff84b 100644 --- a/Tests/RecipientsList/RecipientsListTest.php +++ b/Tests/RecipientsList/RecipientsListTest.php @@ -22,6 +22,7 @@ use D3\LinkmobilityClient\Tests\ApiTestCase; use D3\LinkmobilityClient\ValueObject\Recipient; use libphonenumber\NumberParseException; use libphonenumber\PhoneNumber; +use libphonenumber\PhoneNumberFormat; use libphonenumber\PhoneNumberType; use libphonenumber\PhoneNumberUtil; use PHPUnit\Framework\MockObject\MockObject; @@ -35,7 +36,7 @@ class RecipientsListTest extends ApiTestCase /** @var RecipientsList */ public $recipientsList; - private $phoneNumberFixture = '01527565839'; + private $phoneNumberFixture; private $phoneCountryFixture = 'DE'; /** @@ -51,6 +52,10 @@ class RecipientsListTest extends ApiTestCase ->getMock(); $this->recipientsList = new RecipientsList($clientMock); + + $phoneUtil = PhoneNumberUtil::getInstance(); + $example = $phoneUtil->getExampleNumberForType($this->phoneCountryFixture, PhoneNumberType::MOBILE); + $this->phoneNumberFixture = $phoneUtil->format($example, PhoneNumberFormat::NATIONAL); } /** diff --git a/Tests/Request/AbstractRequest.php b/Tests/Request/AbstractRequest.php index 8c3d097..a669164 100644 --- a/Tests/Request/AbstractRequest.php +++ b/Tests/Request/AbstractRequest.php @@ -24,6 +24,9 @@ use D3\LinkmobilityClient\SMS\Response; use D3\LinkmobilityClient\Tests\ApiTestCase; use D3\LinkmobilityClient\ValueObject\Recipient; use D3\LinkmobilityClient\ValueObject\Sender; +use libphonenumber\PhoneNumberFormat; +use libphonenumber\PhoneNumberType; +use libphonenumber\PhoneNumberUtil; use PHPUnit\Framework\MockObject\MockObject; use Psr\Http\Message\ResponseInterface; use Psr\Http\Message\StreamInterface; @@ -112,7 +115,11 @@ abstract class AbstractRequest extends ApiTestCase */ public function validatePassedTest() { - $recipient = new Recipient('015792300219', 'DE'); + $phoneUtil = PhoneNumberUtil::getInstance(); + $example = $phoneUtil->getExampleNumberForType('DE', PhoneNumberType::MOBILE); + $phoneNumberFixture = $phoneUtil->format($example, PhoneNumberFormat::NATIONAL); + + $recipient = new Recipient($phoneNumberFixture, 'DE'); /** @var Request|MockObject $requestMock */ $requestMock = $this->getMockBuilder($this->testClassName) @@ -139,7 +146,11 @@ abstract class AbstractRequest extends ApiTestCase */ public function validateFailedTest() { - $recipient = new Recipient('015792300219', 'DE'); + $phoneUtil = PhoneNumberUtil::getInstance(); + $example = $phoneUtil->getExampleNumberForType('DE', PhoneNumberType::MOBILE); + $phoneNumberFixture = $phoneUtil->format($example, PhoneNumberFormat::NATIONAL); + + $recipient = new Recipient($phoneNumberFixture, 'DE'); /** @var Request|MockObject $requestMock */ $requestMock = $this->getMockBuilder($this->testClassName) diff --git a/Tests/ValueObject/RecipientTest.php b/Tests/ValueObject/RecipientTest.php index b3611e9..ffe8ddc 100644 --- a/Tests/ValueObject/RecipientTest.php +++ b/Tests/ValueObject/RecipientTest.php @@ -20,6 +20,8 @@ use D3\LinkmobilityClient\Tests\ApiTestCase; use D3\LinkmobilityClient\ValueObject\Recipient; use libphonenumber\NumberParseException; use libphonenumber\PhoneNumber; +use libphonenumber\PhoneNumberFormat; +use libphonenumber\PhoneNumberType; use libphonenumber\PhoneNumberUtil; use PHPUnit\Framework\MockObject\MockObject; use ReflectionException; @@ -29,7 +31,7 @@ class RecipientTest extends ApiTestCase /** @var Recipient */ public $recipient; - private $phoneNumberFixture = '01527565839'; + private $phoneNumberFixture; private $phoneCountryFixture = 'DE'; /** @@ -40,6 +42,10 @@ class RecipientTest extends ApiTestCase { parent::setUp(); + $phoneUtil = PhoneNumberUtil::getInstance(); + $example = $phoneUtil->getExampleNumberForType($this->phoneCountryFixture, PhoneNumberType::MOBILE); + $this->phoneNumberFixture = $phoneUtil->format($example, PhoneNumberFormat::NATIONAL); + $this->recipient = new Recipient($this->phoneNumberFixture, $this->phoneCountryFixture); } diff --git a/Tests/ValueObject/SenderTest.php b/Tests/ValueObject/SenderTest.php index 236679c..4d702fb 100644 --- a/Tests/ValueObject/SenderTest.php +++ b/Tests/ValueObject/SenderTest.php @@ -21,6 +21,8 @@ use D3\LinkmobilityClient\Tests\ApiTestCase; use D3\LinkmobilityClient\ValueObject\Sender; use libphonenumber\NumberParseException; use libphonenumber\PhoneNumber; +use libphonenumber\PhoneNumberFormat; +use libphonenumber\PhoneNumberType; use libphonenumber\PhoneNumberUtil; use PHPUnit\Framework\MockObject\MockObject; use ReflectionException; @@ -30,7 +32,7 @@ class SenderTest extends ApiTestCase /** @var Sender */ public $sender; - private $phoneNumberFixture = '015792300219'; + private $phoneNumberFixture; private $phoneCountryFixture = 'DE'; /** @@ -42,7 +44,13 @@ class SenderTest extends ApiTestCase { parent::setUp(); + $phoneUtil = PhoneNumberUtil::getInstance(); + $example = $phoneUtil->getExampleNumberForType($this->phoneCountryFixture, PhoneNumberType::MOBILE); + $this->phoneNumberFixture = $phoneUtil->format($example, PhoneNumberFormat::NATIONAL); + $this->sender = new Sender($this->phoneNumberFixture, $this->phoneCountryFixture); + + } /**