From a383976e49bf45976c9f35eb54412db5a86f2393 Mon Sep 17 00:00:00 2001 From: Daniel Seifert Date: Tue, 10 Jan 2023 23:35:52 +0100 Subject: [PATCH] apply code style rules --- src/Application/Model/MessageSender.php | 3 ++- src/IntelliSenseHelper.php | 4 +++- src/Modules/LinkmobilityServices.php | 2 +- src/Setup/Actions.php | 2 +- .../unit/Application/Controller/Admin/AdminOrderTest.php | 2 +- src/tests/unit/Application/Controller/Admin/AdminSend.php | 2 +- src/tests/unit/Application/Controller/Admin/AdminUserTest.php | 2 +- src/tests/unit/Application/Model/ConfigurationTest.php | 2 +- .../Model/Exceptions/noRecipientFoundExceptionTest.php | 2 +- .../Model/Exceptions/successfullySentExceptionTest.php | 2 +- src/tests/unit/Application/Model/MessageClientTest.php | 2 +- src/tests/unit/Application/Model/MessageSenderTest.php | 4 ++-- src/tests/unit/Application/Model/MessageTypes/SmsTest.php | 2 +- src/tests/unit/Application/Model/OrderRecipientsTest.php | 2 +- src/tests/unit/Application/Model/RequestFactoryTest.php | 2 +- src/tests/unit/Application/Model/UserRecipientsTest.php | 2 +- src/tests/unit/Modules/Application/Model/OrderModelTest.php | 2 +- src/tests/unit/Modules/Core/EmailCoreTest.php | 2 +- src/tests/unit/Modules/LinkMobilityServicesTest.php | 2 +- src/tests/unit/Setup/ActionsTest.php | 2 +- 20 files changed, 24 insertions(+), 21 deletions(-) diff --git a/src/Application/Model/MessageSender.php b/src/Application/Model/MessageSender.php index 6817052..3487c37 100644 --- a/src/Application/Model/MessageSender.php +++ b/src/Application/Model/MessageSender.php @@ -69,8 +69,9 @@ class MessageSender */ public function sendMessageByOrder(Order $order, string $messageBody): void { - if ((bool) strlen(trim($messageBody)) === false) + if ((bool) strlen(trim($messageBody)) === false) { return; + } try { d3GetOxidDIC()->setParameter(Sms::class.'.args.message', $messageBody); diff --git a/src/IntelliSenseHelper.php b/src/IntelliSenseHelper.php index 72666a0..158eb11 100644 --- a/src/IntelliSenseHelper.php +++ b/src/IntelliSenseHelper.php @@ -17,7 +17,9 @@ namespace D3\Linkmobility4OXID\Modules { use D3\DIContainerHandler\definitionFileContainer; - class LinkmobilityServices_parent extends definitionFileContainer {} + class LinkmobilityServices_parent extends definitionFileContainer + { + } } namespace D3\Linkmobility4OXID\Modules\Application\Model { diff --git a/src/Modules/LinkmobilityServices.php b/src/Modules/LinkmobilityServices.php index 4e8c997..5e06a7b 100644 --- a/src/Modules/LinkmobilityServices.php +++ b/src/Modules/LinkmobilityServices.php @@ -26,4 +26,4 @@ class LinkmobilityServices extends LinkmobilityServices_parent $this->d3CallMockableFunction([LinkmobilityServices_parent::class, '__construct']); $this->addYamlDefinitions('d3/linkmobility/Config/services.yaml'); } -} \ No newline at end of file +} diff --git a/src/Setup/Actions.php b/src/Setup/Actions.php index f09792c..96728c6 100644 --- a/src/Setup/Actions.php +++ b/src/Setup/Actions.php @@ -182,4 +182,4 @@ class Actions { return ContainerFactory::getInstance()->getContainer(); } -} \ No newline at end of file +} diff --git a/src/tests/unit/Application/Controller/Admin/AdminOrderTest.php b/src/tests/unit/Application/Controller/Admin/AdminOrderTest.php index 5d7bf3d..c6b55fe 100644 --- a/src/tests/unit/Application/Controller/Admin/AdminOrderTest.php +++ b/src/tests/unit/Application/Controller/Admin/AdminOrderTest.php @@ -101,4 +101,4 @@ class AdminOrderTest extends AdminSend ) ); } -} \ No newline at end of file +} diff --git a/src/tests/unit/Application/Controller/Admin/AdminSend.php b/src/tests/unit/Application/Controller/Admin/AdminSend.php index 03a5176..0bcb7a8 100644 --- a/src/tests/unit/Application/Controller/Admin/AdminSend.php +++ b/src/tests/unit/Application/Controller/Admin/AdminSend.php @@ -392,4 +392,4 @@ class AdminSend extends LMUnitTestCase ) ); } -} \ No newline at end of file +} diff --git a/src/tests/unit/Application/Controller/Admin/AdminUserTest.php b/src/tests/unit/Application/Controller/Admin/AdminUserTest.php index 8cedc53..7a6b2b7 100644 --- a/src/tests/unit/Application/Controller/Admin/AdminUserTest.php +++ b/src/tests/unit/Application/Controller/Admin/AdminUserTest.php @@ -101,4 +101,4 @@ class AdminUserTest extends AdminSend ) ); } -} \ No newline at end of file +} diff --git a/src/tests/unit/Application/Model/ConfigurationTest.php b/src/tests/unit/Application/Model/ConfigurationTest.php index 0820763..8db835b 100644 --- a/src/tests/unit/Application/Model/ConfigurationTest.php +++ b/src/tests/unit/Application/Model/ConfigurationTest.php @@ -539,4 +539,4 @@ class ConfigurationTest extends LMUnitTestCase 'zero value' => [0, false] ]; } -} \ No newline at end of file +} diff --git a/src/tests/unit/Application/Model/Exceptions/noRecipientFoundExceptionTest.php b/src/tests/unit/Application/Model/Exceptions/noRecipientFoundExceptionTest.php index a6c35d1..747de30 100644 --- a/src/tests/unit/Application/Model/Exceptions/noRecipientFoundExceptionTest.php +++ b/src/tests/unit/Application/Model/Exceptions/noRecipientFoundExceptionTest.php @@ -45,4 +45,4 @@ class noRecipientFoundExceptionTest extends LMUnitTestCase ) ); } -} \ No newline at end of file +} diff --git a/src/tests/unit/Application/Model/Exceptions/successfullySentExceptionTest.php b/src/tests/unit/Application/Model/Exceptions/successfullySentExceptionTest.php index 63d4c4f..1f82f6d 100644 --- a/src/tests/unit/Application/Model/Exceptions/successfullySentExceptionTest.php +++ b/src/tests/unit/Application/Model/Exceptions/successfullySentExceptionTest.php @@ -54,4 +54,4 @@ class successfullySentExceptionTest extends LMUnitTestCase ) ); } -} \ No newline at end of file +} diff --git a/src/tests/unit/Application/Model/MessageClientTest.php b/src/tests/unit/Application/Model/MessageClientTest.php index 6dbab22..230a1a7 100644 --- a/src/tests/unit/Application/Model/MessageClientTest.php +++ b/src/tests/unit/Application/Model/MessageClientTest.php @@ -62,4 +62,4 @@ class MessageClientTest extends LMUnitTestCase $loggerHandler->getLogger() ); } -} \ No newline at end of file +} diff --git a/src/tests/unit/Application/Model/MessageSenderTest.php b/src/tests/unit/Application/Model/MessageSenderTest.php index 346e016..2385db7 100644 --- a/src/tests/unit/Application/Model/MessageSenderTest.php +++ b/src/tests/unit/Application/Model/MessageSenderTest.php @@ -167,7 +167,7 @@ class MessageSenderTest extends LMUnitTestCase ->getMock(); $smsMock->expects($invocationCount)->method('sendOrderMessage')->will( $throwException ? - $this->throwException(d3GetOxidDIC()->get(noRecipientFoundException::class)): + $this->throwException(d3GetOxidDIC()->get(noRecipientFoundException::class)) : $this->returnValue(true) ); d3GetOxidDIC()->set(Sms::class, $smsMock); @@ -223,4 +223,4 @@ class MessageSenderTest extends LMUnitTestCase ) ); } -} \ No newline at end of file +} diff --git a/src/tests/unit/Application/Model/MessageTypes/SmsTest.php b/src/tests/unit/Application/Model/MessageTypes/SmsTest.php index dc8234e..45ce68d 100644 --- a/src/tests/unit/Application/Model/MessageTypes/SmsTest.php +++ b/src/tests/unit/Application/Model/MessageTypes/SmsTest.php @@ -815,4 +815,4 @@ class SmsTest extends LMUnitTestCase ) ); } -} \ No newline at end of file +} diff --git a/src/tests/unit/Application/Model/OrderRecipientsTest.php b/src/tests/unit/Application/Model/OrderRecipientsTest.php index eba2305..d81a0c7 100644 --- a/src/tests/unit/Application/Model/OrderRecipientsTest.php +++ b/src/tests/unit/Application/Model/OrderRecipientsTest.php @@ -234,4 +234,4 @@ class OrderRecipientsTest extends LMUnitTestCase 'fields not configured' => [[], ['oxdelfon' => 'oxdelcountryid', 'oxbillfon' => 'oxbillcountryid']], ]; } -} \ No newline at end of file +} diff --git a/src/tests/unit/Application/Model/RequestFactoryTest.php b/src/tests/unit/Application/Model/RequestFactoryTest.php index 3e95b5c..f592543 100644 --- a/src/tests/unit/Application/Model/RequestFactoryTest.php +++ b/src/tests/unit/Application/Model/RequestFactoryTest.php @@ -72,4 +72,4 @@ class RequestFactoryTest extends LMUnitTestCase ) ); } -} \ No newline at end of file +} diff --git a/src/tests/unit/Application/Model/UserRecipientsTest.php b/src/tests/unit/Application/Model/UserRecipientsTest.php index b085e5e..a1231a8 100644 --- a/src/tests/unit/Application/Model/UserRecipientsTest.php +++ b/src/tests/unit/Application/Model/UserRecipientsTest.php @@ -234,4 +234,4 @@ class UserRecipientsTest extends LMUnitTestCase 'fields not configured' => [[], ['oxmobfon', 'oxfon', 'oxprivfon']], ]; } -} \ No newline at end of file +} diff --git a/src/tests/unit/Modules/Application/Model/OrderModelTest.php b/src/tests/unit/Modules/Application/Model/OrderModelTest.php index a517cce..8f5f3dd 100644 --- a/src/tests/unit/Modules/Application/Model/OrderModelTest.php +++ b/src/tests/unit/Modules/Application/Model/OrderModelTest.php @@ -80,4 +80,4 @@ class OrderModelTest extends LMUnitTestCase 'not canceled' => [false, $this->never()], ]; } -} \ No newline at end of file +} diff --git a/src/tests/unit/Modules/Core/EmailCoreTest.php b/src/tests/unit/Modules/Core/EmailCoreTest.php index 8fcbe5e..ca7f37a 100644 --- a/src/tests/unit/Modules/Core/EmailCoreTest.php +++ b/src/tests/unit/Modules/Core/EmailCoreTest.php @@ -349,4 +349,4 @@ class EmailCoreTest extends LMUnitTestCase ) ); } -} \ No newline at end of file +} diff --git a/src/tests/unit/Modules/LinkMobilityServicesTest.php b/src/tests/unit/Modules/LinkMobilityServicesTest.php index 3f4e9c8..6709739 100644 --- a/src/tests/unit/Modules/LinkMobilityServicesTest.php +++ b/src/tests/unit/Modules/LinkMobilityServicesTest.php @@ -48,4 +48,4 @@ class LinkMobilityServicesTest extends LMUnitTestCase '__construct' ); } -} \ No newline at end of file +} diff --git a/src/tests/unit/Setup/ActionsTest.php b/src/tests/unit/Setup/ActionsTest.php index 95ad975..8c20188 100644 --- a/src/tests/unit/Setup/ActionsTest.php +++ b/src/tests/unit/Setup/ActionsTest.php @@ -296,4 +296,4 @@ class ActionsTest extends LMUnitTestCase ) ); } -} \ No newline at end of file +}