[Changed] metadata && changelog

.noencode

@@ -0,0 +1 @@
+copyAsIsFiles=metadata.php, .php-cs-fixer.php, IntelliSenseHelper.php, migration, Application/views

.php-cs-fixer.php

@@ -0,0 +1,34 @@
+<?php
+	
+	$finder = PhpCsFixer\Finder::create()
+		->in(__DIR__)
+	;
+	
+	$header = <<<EOF
+Copyright (c) D3 Data Development (Inh. Thomas Dartsch)
+
+For the full copyright and license information, please view
+the LICENSE file that was distributed with this source code.
+
+https://www.d3data.de
+
+@copyright (C) D3 Data Development (Inh. Thomas Dartsch)
+@author    D3 Data Development - Max Buhe, Daniel Seifert <info@shopmodule.com>
+@link      https://www.oxidmodule.com
+EOF;
+	
+	$config = new PhpCsFixer\Config();
+	return $config->setRules([
+		'@PHP80Migration' => true,
+		'@PSR12' => true,
+		'header_comment' => [
+			'comment_type' => 'PHPDoc',
+			'header' => $header,
+			'location' => 'after_open',
+			'separate' => 'both',
+		],
+		'php_unit_test_class_requires_covers' => true,
+		'doctrine_annotation_indentation' => true,
+	])
+		->setFinder($finder)
+;

Application/Controller/Admin/ManufacturerInfoLongdesc.php

@@ -1,5 +1,18 @@
 <?php
-	
+
+/**
+ * Copyright (c) D3 Data Development (Inh. Thomas Dartsch)
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ *
+ * https://www.d3data.de
+ *
+ * @copyright (C) D3 Data Development (Inh. Thomas Dartsch)
+ * @author    D3 Data Development - Max Buhe, Daniel Seifert <info@shopmodule.com>
+ * @link      https://www.oxidmodule.com
+ */
+
 declare(strict_types=1);
 
 namespace D3\ManufacturerInformation\Application\Controller\Admin;
@@ -12,118 +25,118 @@ use OxidEsales\Eshop\Core\Registry;
 
 class ManufacturerInfoLongdesc extends AdminDetailsController
 {
-	/**
+    /**
-	 * @return string
+     * @return string
-	 */
+     */
-	public function render()
+    public function render()
-	{
+    {
-		parent::render();
+        parent::render();
-		
+
-		/** @var Manufacturer|D3ManufacturerLongDesc $oManufacturer */
+        /** @var Manufacturer|D3ManufacturerLongDesc $oManufacturer */
-		$this->_aViewData['edit'] = $oManufacturer = oxNew(\OxidEsales\Eshop\Application\Model\Manufacturer::class);
+        $this->_aViewData['edit'] = $oManufacturer = oxNew(\OxidEsales\Eshop\Application\Model\Manufacturer::class);
-		
+
-		$sOXID = $this->_aViewData["oxid"] = $this->getEditObjectId();
+        $sOXID = $this->_aViewData["oxid"] = $this->getEditObjectId();
-		if (isset($sOXID) && $sOXID != "-1") {
+        if (isset($sOXID) && $sOXID != "-1") {
-			// load object
+            // load object
-			$d3manufacturerlang = \OxidEsales\Eshop\Core\Registry::getRequest()->getRequestEscapedParameter("catlang");
+            $d3manufacturerlang = \OxidEsales\Eshop\Core\Registry::getRequest()->getRequestEscapedParameter("catlang");
-			
+
-			if (!isset($d3manufacturerlang)) {
+            if (!isset($d3manufacturerlang)) {
-				$d3manufacturerlang = $this->_iEditLang;
+                $d3manufacturerlang = $this->_iEditLang;
-			}
+            }
-			
+
-			$this->_aViewData["catlang"] = $d3manufacturerlang;
+            $this->_aViewData["catlang"] = $d3manufacturerlang;
-			
+
-			$oManufacturer->loadInLang($d3manufacturerlang, $sOXID);
+            $oManufacturer->loadInLang($d3manufacturerlang, $sOXID);
-			
+
-			//Disable editing for derived items
+            //Disable editing for derived items
-			if ($oManufacturer->isDerived()) {
+            if ($oManufacturer->isDerived()) {
-				$this->_aViewData['readonly'] = true;
+                $this->_aViewData['readonly'] = true;
-			}
+            }
-			
+
-			foreach (\OxidEsales\Eshop\Core\Registry::getLang()->getLanguageNames() as $id => $language) {
+            foreach (\OxidEsales\Eshop\Core\Registry::getLang()->getLanguageNames() as $id => $language) {
-				$oLang = new \stdClass();
+                $oLang = new \stdClass();
-				$oLang->sLangDesc = $language;
+                $oLang->sLangDesc = $language;
-				$oLang->selected = ($id == $this->_iEditLang);
+                $oLang->selected = ($id == $this->_iEditLang);
-				$this->_aViewData["otherlang"][$id] = clone $oLang;
+                $this->_aViewData["otherlang"][$id] = clone $oLang;
-			}
+            }
-		}
+        }
-		
+
-		$this->_aViewData["editor"] = $this->generateTextEditor("100%", 280, $oManufacturer, $oManufacturer->getD3LongDescTableColumnName(), "list.css");
+        $this->_aViewData["editor"] = $this->generateTextEditor("100%", 280, $oManufacturer, $oManufacturer->getD3LongDescTableColumnName(), "list.css");
-		
+
-		return "@d3manufacturerinformation/admin/d3manufacturerlongdesc";
+        return "@d3manufacturerinformation/admin/d3manufacturerlongdesc";
-	}
+    }
-	
+
-	/**
+    /**
-	 * @return void
+     * @return void
-	 * @throws \Exception
+     * @throws \Exception
-	 */
+     */
-	public function save()
+    public function save()
-	{
+    {
-		parent::save();
+        parent::save();
-		
+
-		$iManufacturerLang = intval(\OxidEsales\Eshop\Core\Registry::getRequest()->getRequestEscapedParameter("catlang"));
+        $iManufacturerLang = intval(\OxidEsales\Eshop\Core\Registry::getRequest()->getRequestEscapedParameter("catlang"));
-		$sOXID = $this->getEditObjectId();
+        $sOXID = $this->getEditObjectId();
-		$this->setEditObjectId($sOXID);
+        $this->setEditObjectId($sOXID);
-		
+
-		if ($sOXID == "-1") {
+        if ($sOXID == "-1") {
-			return;
+            return;
-		}
+        }
-		
+
-		/** @var Manufacturer|D3ManufacturerLongDesc $oManufacturer */
+        /** @var Manufacturer|D3ManufacturerLongDesc $oManufacturer */
-		$oManufacturer = oxNew(Manufacturer::class);
+        $oManufacturer = oxNew(Manufacturer::class);
-		$oManufacturer->loadInLang($iManufacturerLang, $sOXID);
+        $oManufacturer->loadInLang($iManufacturerLang, $sOXID);
-		
+
-		if (!$oManufacturer->load($sOXID)) {
+        if (!$oManufacturer->load($sOXID)) {
-			return;
+            return;
-		}
+        }
-		
+
-		$aParams = Registry::getRequest()->getRequestEscapedParameter("editval");
+        $aParams = Registry::getRequest()->getRequestEscapedParameter("editval");
-		$oManufacturer->assign($aParams);
+        $oManufacturer->assign($aParams);
-		
+
-		if (false === is_null($this->d3GetLongdescParamValue($oManufacturer))) {
+        if (false === is_null($this->d3GetLongdescParamValue($oManufacturer))) {
-			$oManufacturer->d3SetLongdesc($this->d3GetLongdescParamValue($oManufacturer));
+            $oManufacturer->d3SetLongdesc($this->d3GetLongdescParamValue($oManufacturer));
-			$oManufacturer->save();
+            $oManufacturer->save();
-		}
+        }
-	}
+    }
-	
+
-	/**
+    /**
-	 * @param $oManufacturer
+     * @param $oManufacturer
-	 * @param $sField
+     * @param $sField
-	 * @return string
+     * @return string
-	 */
+     */
-	protected function getEditValue($oManufacturer, $sField)
+    protected function getEditValue($oManufacturer, $sField)
-	{
+    {
-		$sEditObjectValue = '';
+        $sEditObjectValue = '';
-		
+
-		if ($oManufacturer and $oManufacturer->getId()) {
+        if ($oManufacturer and $oManufacturer->getId()) {
-			$sEditObjectValue = $oManufacturer->getFieldData(Constants::D3_OXMANUFACTURERS_LONGDESC_FIELDNAME);
+            $sEditObjectValue = $oManufacturer->getFieldData(Constants::D3_OXMANUFACTURERS_LONGDESC_FIELDNAME);
-		}
+        }
-		
+
-		return $sEditObjectValue;
+        return $sEditObjectValue;
-	}
+    }
-	
+
-	/**
+    /**
-	 * @param Manufacturer|D3ManufacturerLongDesc $oManufacturer
+     * @param Manufacturer|D3ManufacturerLongDesc $oManufacturer
-	 * @return string
+     * @return string
-	 */
+     */
-	public function d3GetLongdescParamValue(Manufacturer $oManufacturer) :string
+    public function d3GetLongdescParamValue(Manufacturer $oManufacturer): string
-	{
+    {
-		return (string) $aParams = Registry::getRequest()->getRequestEscapedParameter("editval")[$oManufacturer->getD3LongDescTableColumnName()];
+        return (string) $aParams = Registry::getRequest()->getRequestEscapedParameter("editval")[$oManufacturer->getD3LongDescTableColumnName()];
-	}
+    }
-	
+
-	/**
+    /**
-	 * inhaltliche Uebernahme analog Article_Main
+     * inhaltliche Uebernahme analog Article_Main
-	 * wird genutzt zum Abspeichern der Artikel-Langbeschreibung
+     * wird genutzt zum Abspeichern der Artikel-Langbeschreibung
-	 *
+     *
-	 * @param $sValue
+     * @param $sValue
-	 *
+     *
-	 * @return mixed
+     * @return mixed
-	 */
+     */
-	protected function processLongDesc($sValue)
+    protected function processLongDesc($sValue)
-	{
+    {
-		$aSearch  = ['&amp;nbsp;', '&amp;', '&quot;', '&lang=', '<p>&nbsp;</p>', '<p>&nbsp; </p>'];
+        $aSearch  = ['&amp;nbsp;', '&amp;', '&quot;', '&lang=', '<p>&nbsp;</p>', '<p>&nbsp; </p>'];
-		$aReplace = ['&nbsp;', '&', '"', '&amp;lang=', '', ''];
+        $aReplace = ['&nbsp;', '&', '"', '&amp;lang=', '', ''];
-		
+
-		return str_replace($aSearch, $aReplace, $sValue);
+        return str_replace($aSearch, $aReplace, $sValue);
-	}
+    }
-}
+}

Application/Model/Constants.php

@@ -1,14 +1,26 @@
 <?php
-	
+
+/**
+ * Copyright (c) D3 Data Development (Inh. Thomas Dartsch)
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ *
+ * https://www.d3data.de
+ *
+ * @copyright (C) D3 Data Development (Inh. Thomas Dartsch)
+ * @author    D3 Data Development - Max Buhe, Daniel Seifert <info@shopmodule.com>
+ * @link      https://www.oxidmodule.com
+ */
+
 declare(strict_types=1);
 
 namespace D3\ManufacturerInformation\Application\Model;
 
-
 class Constants
 {
-	public const OXID_MODULE_ID = 'd3manufacturerinformation';
+    public const OXID_MODULE_ID = 'd3manufacturerinformation';
-	
+
-	// Tables and Database
+    // Tables and Database
-	public const D3_OXMANUFACTURERS_LONGDESC_FIELDNAME = 'D3DESCRIPTION';
+    public const D3_OXMANUFACTURERS_LONGDESC_FIELDNAME = 'd3description';
-}
+}

Application/views/admin_smarty/de/d3manufacturerinformation_lang.php

@@ -1,11 +1,26 @@
 <?php
 
+/**
+ * Copyright (c) D3 Data Development (Inh. Thomas Dartsch)
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ *
+ * https://www.d3data.de
+ *
+ * @copyright (C) D3 Data Development (Inh. Thomas Dartsch)
+ * @author    D3 Data Development - Max Buhe, Daniel Seifert <info@shopmodule.com>
+ * @link      https://www.oxidmodule.com
+ */
+
 $sLangName = "Deutsch";
 // -------------------------------
 // RESOURCE IDENTITFIER = STRING
 // -------------------------------
-$aLang = array(
+$aLang = [
     'charset'                                   => 'UTF-8',
-	
+
-    'mxd3manufacturerinfolongdesc'                                   => 'Langtext',
+    'mxd3manufacturerinfolongdesc'                         => 'Langtext',
-);
+    'SHOP_MODULE_GROUP_d3manufacturerinformation_main'     => 'Einstellungen',
+    'SHOP_MODULE_d3manufacturerinformation_showManufacturertextOnDetailsPage'   => 'vorhandene Herstellertexte auf Artikeldetails als Tab anzeigen',
+];

Application/views/admin_smarty/en/d3manufacturerinformation_lang.php

@@ -1,11 +1,26 @@
 <?php
 
+/**
+ * Copyright (c) D3 Data Development (Inh. Thomas Dartsch)
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ *
+ * https://www.d3data.de
+ *
+ * @copyright (C) D3 Data Development (Inh. Thomas Dartsch)
+ * @author    D3 Data Development - Max Buhe, Daniel Seifert <info@shopmodule.com>
+ * @link      https://www.oxidmodule.com
+ */
+
 $sLangName = "Deutsch";
 // -------------------------------
 // RESOURCE IDENTITFIER = STRING
 // -------------------------------
-$aLang = array(
+$aLang = [
-	'charset'                                   => 'UTF-8',
+    'charset'                                   => 'UTF-8',
-	
+
-	'mxd3manufacturerinfolongdesc'                                   => 'Text',
+    'mxd3manufacturerinfolongdesc'                         => 'Text',
-);
+    'SHOP_MODULE_GROUP_d3manufacturerinformation_main'     => 'Settings',
+    'SHOP_MODULE_d3manufacturerinformation_showManufacturertextOnDetailsPage'   => 'display existing manufacturer texts on item details as a tab',
+];

Application/views/admin_twig/de/d3manufacturerinformation_lang.php

@@ -1,11 +1,26 @@
 <?php
 
+/**
+ * Copyright (c) D3 Data Development (Inh. Thomas Dartsch)
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ *
+ * https://www.d3data.de
+ *
+ * @copyright (C) D3 Data Development (Inh. Thomas Dartsch)
+ * @author    D3 Data Development - Max Buhe, Daniel Seifert <info@shopmodule.com>
+ * @link      https://www.oxidmodule.com
+ */
+
 $sLangName = "Deutsch";
 // -------------------------------
 // RESOURCE IDENTITFIER = STRING
 // -------------------------------
-$aLang = array(
+$aLang = [
     'charset'                                   => 'UTF-8',
-	
+
-    'mxd3manufacturerinfolongdesc'                                   => 'Langtext',
+    'mxd3manufacturerinfolongdesc'                         => 'Langtext',
-);
+    'SHOP_MODULE_GROUP_d3manufacturerinformation_main'     => 'Einstellungen',
+    'SHOP_MODULE_d3manufacturerinformation_showManufacturertextOnDetailsPage'   => 'vorhandene Herstellertexte auf Artikeldetails als Tab anzeigen',
+];

Application/views/admin_twig/en/d3manufacturerinformation_lang.php

@@ -1,11 +1,26 @@
 <?php
 
+/**
+ * Copyright (c) D3 Data Development (Inh. Thomas Dartsch)
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ *
+ * https://www.d3data.de
+ *
+ * @copyright (C) D3 Data Development (Inh. Thomas Dartsch)
+ * @author    D3 Data Development - Max Buhe, Daniel Seifert <info@shopmodule.com>
+ * @link      https://www.oxidmodule.com
+ */
+
 $sLangName = "Deutsch";
 // -------------------------------
 // RESOURCE IDENTITFIER = STRING
 // -------------------------------
-$aLang = array(
+$aLang = [
-	'charset'                                   => 'UTF-8',
+    'charset'                                   => 'UTF-8',
-	
+
-	'mxd3manufacturerinfolongdesc'                                   => 'Text',
+    'mxd3manufacturerinfolongdesc'                         => 'Text',
-);
+    'SHOP_MODULE_GROUP_d3manufacturerinformation_main'     => 'Settings',
+    'SHOP_MODULE_d3manufacturerinformation_showManufacturertextOnDetailsPage'   => 'display existing manufacturer texts on item details as a tab',
+];

Application/views/blocks/page/details/inc/details_productmain_manufacturersicon.html.tpl

@@ -0,0 +1,10 @@
+[{if $oManufacturer->oxmanufacturers__oxicon->value}]
+    [{$smarty.block.parent}]
+[{else}]
+    <div class="action-links text-left">
+        <a href="[{$oManufacturer->getLink()}]" title="[{$oManufacturer->oxmanufacturers__oxtitle->value}]">
+            [{oxmultilang ident="MANUFACTURER" suffix="COLON"}] [{$oManufacturer->oxmanufacturers__oxtitle->value}]
+        </a>
+        <span itemprop="brand" class="hidden">[{$oManufacturer->oxmanufacturers__oxtitle->value}]</span>
+    </div>
+[{/if}]

Application/views/blocks/page/details/inc/details_tabs_invite.html.tpl

@@ -0,0 +1,16 @@
+[{$smarty.block.parent}]
+
+[{assign var="oConfig"       value=$oViewConf->getConfig()}]
+[{assign var="oManufacturer" value=$oView->getManufacturer()}]
+[{assign var="sShopURL"      value=$oConfig->getConfigParam('sShopURL')}]
+[{assign var="description"   value=$oManufacturer->d3GetLongdesc()}]
+
+[{if $oManufacturer && $oConfig->getConfigParam('d3manufacturerinformation_showManufacturertextOnDetailsPage') && $description->rawValue|strip_tags|trim}]
+    [{capture append="tabs"}]<a href="#manufacturertab" data-toggle="tab">[{oxmultilang ident="MANUFACTURER"}]</a>[{/capture}]
+        [{capture append="tabsContent"}]
+        <div id="manufacturertab" class="tab-pane[{if $blFirstTab}] active[{/if}]">
+            [{oxeval var=$description}]
+        </div>
+        [{assign var="blFirstTab" value=false}]
+    [{/capture}]
+[{/if}]

CHANGELOG.md

@@ -4,10 +4,39 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.1.0.0](https://git.d3data.de/D3Public/MyModule/compare/1.1.1.0...1.1.2.0) - 2024-11-20
+### Fixed
+- show hidden save button
+- installation instructions
+- show manufacturer link on article details page, if manufacturer hasn't an icon
+- prevent encoding HTML entities
+
+### Added
+- display manufacturer content as additional tab on article details page
+- make displaying manufacturer tab on details page configurable
+- hide empty HTML elements content
+
 ## [2.0.0.0](https://git.d3data.de/D3Public/MyModule/compare/1.0.0.0...1.1.0.0) - 2024-11-16
 ### Added
 - installability OXID 7.0 - 7.1
 
+## [1.1.2.0](https://git.d3data.de/D3Public/MyModule/compare/1.1.1.0...1.1.2.0) - 2024-11-19
+### Fixed
+- show hidden save button
+
+### Added
+- hide empty HTML elements content
+
+## [1.1.1.0](https://git.d3data.de/D3Public/MyModule/compare/1.1.0.0...1.1.1.0) - 2024-11-18
+### Fixed
+- installation instructions
+- show manufacturer link on article details page, if manufacturer hasn't an icon
+- prevent encoding HTML entities
+
+### Added
+- display manufacturer content as additional tab on article details page
+- make displaying manufacturer tab on details page configurable
+
 ## [1.1.0.0](https://git.d3data.de/D3Public/MyModule/compare/1.0.0.0...1.1.0.0) - 2024-11-13
 ### Added
 - installability OXID 6.2.3 - 6.5.x

IntelliSenseHelper.php

@@ -1,24 +1,28 @@
 <?php
 
 /**
- * This Software is the property of Data Development and is protected
+ * Copyright (c) D3 Data Development (Inh. Thomas Dartsch)
- * by copyright law - it is NOT Freeware.
+ *
- * Any unauthorized use of this software without a valid license
+ * For the full copyright and license information, please view
- * is a violation of the license agreement and will be prosecuted by
+ * the LICENSE file that was distributed with this source code.
- * civil and criminal law.
+ *
- * http://www.shopmodule.com
+ * https://www.d3data.de
  *
  * @copyright (C) D3 Data Development (Inh. Thomas Dartsch)
- * @author        D3 Data Development - Daniel Seifert <support@shopmodule.com>
+ * @author    D3 Data Development - Max Buhe, Daniel Seifert <info@shopmodule.com>
- * @link          http://www.oxidmodule.com
+ * @link      https://www.oxidmodule.com
  */
 
 namespace D3\ManufacturerInformation\Modules\Application\Model{
-	
+
-	use OxidEsales\Eshop\Application\Model\Manufacturer;
+    use OxidEsales\Eshop\Application\Model\Manufacturer;
-	use OxidEsales\Eshop\Application\Model\ManufacturerList;
+    use OxidEsales\Eshop\Application\Model\ManufacturerList;
-	
+
-	class D3ManufacturerLongDesc_parent extends Manufacturer {}
+    class D3ManufacturerLongDesc_parent extends Manufacturer
-	
+    {
-	class ManufacturerInfoList_parent extends ManufacturerList {}
+    }
-}
+
+    class ManufacturerInfoList_parent extends ManufacturerList
+    {
+    }
+}

Modules/Application/Model/D3ManufacturerLongDesc.php

@@ -1,47 +1,59 @@
 <?php
-	
+
+/**
+ * Copyright (c) D3 Data Development (Inh. Thomas Dartsch)
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ *
+ * https://www.d3data.de
+ *
+ * @copyright (C) D3 Data Development (Inh. Thomas Dartsch)
+ * @author    D3 Data Development - Max Buhe, Daniel Seifert <info@shopmodule.com>
+ * @link      https://www.oxidmodule.com
+ */
+
 declare(strict_types=1);
 
 namespace D3\ManufacturerInformation\Modules\Application\Model;
 
-
 use D3\ManufacturerInformation\Application\Model\Constants;
 use OxidEsales\Eshop\Application\Model\Manufacturer;
 use OxidEsales\Eshop\Core\Registry;
 
 class D3ManufacturerLongDesc extends D3ManufacturerLongDesc_parent
 {
-	/**
+    /**
-	 * @param string $sValue
+     * @param string $sValue
-	 * @return void
+     * @return void
-	 */
+     */
-	public function d3SetLongdesc(string $sValue) :bool
+    public function d3SetLongdesc(string $sValue): bool
-	{
+    {
-		if ($this->getId() and $this->isLoaded()){
+        if ($this->getId() and $this->isLoaded()) {
-			try {
+            try {
-				$this->assign([Constants::D3_OXMANUFACTURERS_LONGDESC_FIELDNAME => $sValue]);
+                $this->assign([Constants::D3_OXMANUFACTURERS_LONGDESC_FIELDNAME => $sValue]);
-				$this->save();
+                $this->save();
-			}catch (\Exception $exception){
+            } catch (\Exception $exception) {
-				Registry::getLogger()->error($exception->getMessage());
+                Registry::getLogger()->error($exception->getMessage());
-			}
+            }
-		}
+        }
-		
+
-		return true;
+        return true;
-	}
+    }
-	
+
-	/**
+    /**
-	 * @return string
+     * @return string
-	 */
+     */
-	public function d3GetLongdesc(): string
+    public function d3GetLongdesc(): string
-	{
+    {
-		return $this->getFieldData(Constants::D3_OXMANUFACTURERS_LONGDESC_FIELDNAME);
+        return $this->getFieldData(Constants::D3_OXMANUFACTURERS_LONGDESC_FIELDNAME);
-	}
+    }
-	
+
-	/**
+    /**
-	 * @return string
+     * @return string
-	 */
+     */
-	public function getD3LongDescTableColumnName() :string
+    public function getD3LongDescTableColumnName(): string
-	{
+    {
-		return $sParamName = $this->getViewName(true).'__'.Constants::D3_OXMANUFACTURERS_LONGDESC_FIELDNAME;
+        return $sParamName = $this->getViewName(true).'__'.Constants::D3_OXMANUFACTURERS_LONGDESC_FIELDNAME;
-	}
+    }
-}
+}

Modules/Application/Model/ManufacturerInfoList.php

@@ -1,10 +1,22 @@
 <?php
-	
+
+/**
+ * Copyright (c) D3 Data Development (Inh. Thomas Dartsch)
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ *
+ * https://www.d3data.de
+ *
+ * @copyright (C) D3 Data Development (Inh. Thomas Dartsch)
+ * @author    D3 Data Development - Max Buhe, Daniel Seifert <info@shopmodule.com>
+ * @link      https://www.oxidmodule.com
+ */
+
 declare(strict_types=1);
 
 namespace D3\ManufacturerInformation\Modules\Application\Model;
 
-
 use D3\ManufacturerInformation\Application\Model\Constants;
 use OxidEsales\Eshop\Application\Model\Manufacturer;
 use OxidEsales\Eshop\Application\Model\ManufacturerList;
@@ -12,14 +24,14 @@ use OxidEsales\Eshop\Core\Field;
 
 class ManufacturerInfoList extends ManufacturerInfoList_parent
 {
-	/**
+    /**
-	 * @param Manufacturer|D3ManufacturerLongDesc $oManufacturer
+     * @param Manufacturer|D3ManufacturerLongDesc $oManufacturer
-	 * @return void
+     * @return void
-	 */
+     */
-	protected function addCategoryFields($oManufacturer)
+    protected function addCategoryFields($oManufacturer)
-	{
+    {
-		parent::addCategoryFields($oManufacturer);
+        parent::addCategoryFields($oManufacturer);
-		
+
-		$oManufacturer->oxcategories__oxlongdesc = new Field($oManufacturer->getFieldData(Constants::D3_OXMANUFACTURERS_LONGDESC_FIELDNAME), Field::T_RAW);
+        $oManufacturer->oxcategories__oxlongdesc = new Field($oManufacturer->getFieldData(Constants::D3_OXMANUFACTURERS_LONGDESC_FIELDNAME), Field::T_RAW);
-	}
+    }
-}
+}

README.md

@@ -17,20 +17,22 @@ Dieses Paket erfordert einen mit Composer installierten OXID eShop in einer in d
 
 
 ```bash
-composer require d3/manufacturerinformation:"~2"
+composer require d3/manufacturerinformation:"~2.0.0"
-
-./vendor/bin/oe-eshop-db_migrate migrations:migrate d3manufacturerinformation
-
-./vendor/bin/oe-console oe:module:install ./vendor/d3/manufacturerinformation/
-./vendor/bin/oe-console oe:module:activate d3manufacturerinformation
-./vendor/bin/oe-console oe:module:deactivate d3manufacturerinformation
 ```
 
 Sofern nötig, bestätigen Sie bitte, dass Sie `package-name` erlauben, Code auszuführen.
 
-Aktivieren Sie das Modul im Shopadmin unter "Erweiterungen -> Module".
+```bash
+./vendor/bin/oe-eshop-db_migrate migrations:migrate d3manufacturerinformation
 
-Aktualisieren Sie anschließend die Datenbank-Views und leeren den Temp Ordner des Shops.
+./vendor/bin/oe-console o:m:i source/modules/d3/manufacturerinformation
+./vendor/bin/oe-console o:m:deact d3manufacturerinformation
+./vendor/bin/oe-console o:m:act d3manufacturerinformation
+
+./vendor/bin/oe-eshop-db_views_generate
+```
+
+Leeren Sie anschließend den Temp Ordner des Shops.
 
 
 ## Lizenz

composer.json

@@ -29,9 +29,17 @@
     "php": "^8.0",
     "oxid-esales/oxideshop-ce": "7.0 - 7.1"
   },
+  "require-dev": {
+    "oxid-esales/oxideshop-ce": "~6.14.0",
+    "friendsofphp/php-cs-fixer": "^3.9"
+  },
   "autoload": {
     "psr-4": {
       "D3\\ManufacturerInformation\\": ""
     }
+  },
+  "scripts": {
+    "php-cs-fixer_audit": "./vendor/bin/php-cs-fixer list-files --config=./vendor/d3/manufacturerinformation/.php-cs-fixer.php",
+    "php-cs-fixer_fix": "./vendor/bin/php-cs-fixer fix --config=./vendor/d3/manufacturerinformation/.php-cs-fixer.php"
   }
 }

metadata.php

@@ -1,13 +1,15 @@
 <?php
 
 /**
- * For the full copyright and license information, please view the LICENSE
+ * Copyright (c) D3 Data Development (Inh. Thomas Dartsch)
- * file that was distributed with this source code.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
  *
  * https://www.d3data.de
  *
  * @copyright (C) D3 Data Development (Inh. Thomas Dartsch)
- * @author    D3 Data Development - Daniel Seifert <info@shopmodule.com>
+ * @author    D3 Data Development - Max Buhe, Daniel Seifert <info@shopmodule.com>
  * @link      https://www.oxidmodule.com
  */
 
@@ -27,27 +29,47 @@ $sMetadataVersion = '2.1';
  */
 $aModule = [
     'id'          => Constants::OXID_MODULE_ID,
-	'title'         => [
+    'title'         => [
-		'de'        => '(D3) Herstellerinformationen',
+        'de'        => '(D3) Herstellerinformationen',
-		'en'        => '(D3) Manufacturer information',
+        'en'        => '(D3) Manufacturer information',
-	],
+    ],
-	'description' => [
+    'description' => [
         'de' => 'fügt Informationen der Hersteller zur Artikelliste hinzu',
         'en' => 'adds manufacturer information to the article list',
     ],
     'thumbnail'   => 'image-file.png',
-    'version'     => '2.0.0.0',
+    'version'     => '2.1.0.0',
     'author'      => '(D3) Data Development (Inh.: Thomas Dartsch)',
     'email'       => 'support@shopmodule.com',
     'url'         => 'https://www.oxidmodule.com/',
     'controllers' => [
-		"d3manufacturerinfolongdesc" => ManufacturerInfoLongdesc::class
+        "d3manufacturerinfolongdesc" => ManufacturerInfoLongdesc::class,
     ],
     'extend'      => [
-		OEManufacturer::class => D3ManufacturerLongDesc::class,
+        OEManufacturer::class => D3ManufacturerLongDesc::class,
-	    OEManufacturerList::class => ManufacturerInfoList::class
+        OEManufacturerList::class => ManufacturerInfoList::class,
     ],
     'templates'   => [
-	    '@' . Constants::OXID_MODULE_ID . '/admin/d3manufacturerlongdesc.tpl'        => 'views/smarty/admin/d3manufacturerlongdesc.tpl',
+        '@' . Constants::OXID_MODULE_ID . '/admin/d3manufacturerlongdesc.tpl'        => 'views/smarty/admin/d3manufacturerlongdesc.tpl',
+    ],
+    'settings'    => [
+        [
+            'group'     => Constants::OXID_MODULE_ID.'_main',
+            'name'      => Constants::OXID_MODULE_ID.'_showManufacturertextOnDetailsPage',
+            'type'      => 'bool',
+            'value'     => true,
+        ],
+    ],
+    'blocks'      => [
+        [
+            'template'  => 'page/details/inc/productmain.tpl',
+            'block'     => 'details_productmain_manufacturersicon',
+            'file'      => 'Application/views/blocks/page/details/inc/details_productmain_manufacturersicon.html.tpl',
+        ],
+        [
+            'template'  => 'page/details/inc/tabs.tpl',
+            'block'     => 'details_tabs_invite',
+            'file'      => 'Application/views/blocks/page/details/inc/details_tabs_invite.html.tpl',
+        ],
     ],
 ];

migration/data/Version20241023154223.php

@@ -1,5 +1,18 @@
 <?php
 
+/**
+ * Copyright (c) D3 Data Development (Inh. Thomas Dartsch)
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ *
+ * https://www.d3data.de
+ *
+ * @copyright (C) D3 Data Development (Inh. Thomas Dartsch)
+ * @author    D3 Data Development - Max Buhe, Daniel Seifert <info@shopmodule.com>
+ * @link      https://www.oxidmodule.com
+ */
+
 declare(strict_types=1);
 
 namespace D3\ManufacturerInformation\Migrations;
@@ -13,36 +26,38 @@ use Doctrine\Migrations\AbstractMigration;
  */
 final class Version20241023154223 extends AbstractMigration
 {
-    public function getDescription() : string
+    public function getDescription(): string
     {
         return 'Adds the D3 manufacturer longdesc column';
     }
-	
-	public function up(Schema $schema) : void
-	{
-		$this->connection->getDatabasePlatform()->registerDoctrineTypeMapping('enum', 'string');
-		
-		$this->d3AddLongdescColumnToOxmanufacturers($schema);
-	}
 
-    public function down(Schema $schema) : void
+    public function up(Schema $schema): void
-    {}
+    {
-	
+        $this->connection->getDatabasePlatform()->registerDoctrineTypeMapping('enum', 'string');
-	/**
+
-	 * @param Schema $schema
+        $this->d3AddLongdescColumnToOxmanufacturers($schema);
-	 * @return void
+    }
-	 * @throws \Doctrine\DBAL\Schema\SchemaException
+
-	 */
+    public function down(Schema $schema): void
-	public function d3AddLongdescColumnToOxmanufacturers(Schema $schema){
+    {
-		$table = !$schema->hasTable('oxmanufacturers') ?
+    }
-			$schema->createTable('oxmanufacturers') :
+
-			$schema->getTable('oxmanufacturers');
+    /**
-		
+     * @param Schema $schema
-		// Beschreibung
+     * @return void
-		if (!$table->hasColumn('D3DESCRIPTION')) {
+     * @throws \Doctrine\DBAL\Schema\SchemaException
-			$table->addColumn('D3DESCRIPTION', (new TextType())->getName())
+     */
-				->setLength($this->connection->getDatabasePlatform()::LENGTH_LIMIT_TEXT)
+    public function d3AddLongdescColumnToOxmanufacturers(Schema $schema)
-				->setNotnull(true);
+    {
-		}
+        $table = !$schema->hasTable('oxmanufacturers') ?
-	}
+            $schema->createTable('oxmanufacturers') :
+            $schema->getTable('oxmanufacturers');
+
+        // Beschreibung
+        if (!$table->hasColumn('D3DESCRIPTION')) {
+            $table->addColumn('D3DESCRIPTION', (new TextType())->getName())
+                ->setLength($this->connection->getDatabasePlatform()::LENGTH_LIMIT_TEXT)
+                ->setNotnull(true);
+        }
+    }
 }

migration/data/Version20241028172608.php

@@ -1,5 +1,18 @@
 <?php
 
+/**
+ * Copyright (c) D3 Data Development (Inh. Thomas Dartsch)
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ *
+ * https://www.d3data.de
+ *
+ * @copyright (C) D3 Data Development (Inh. Thomas Dartsch)
+ * @author    D3 Data Development - Max Buhe, Daniel Seifert <info@shopmodule.com>
+ * @link      https://www.oxidmodule.com
+ */
+
 declare(strict_types=1);
 
 namespace D3\ManufacturerInformation\Migrations;
@@ -13,50 +26,52 @@ use Doctrine\Migrations\AbstractMigration;
  */
 final class Version20241028172608 extends AbstractMigration
 {
-    public function getDescription() : string
+    public function getDescription(): string
     {
-	    return 'Adds multilang tables for the D3 manufacturer longdesc';
+        return 'Adds multilang tables for the D3 manufacturer longdesc';
     }
-	
-	public function up(Schema $schema) : void
-	{
-		$this->connection->getDatabasePlatform()->registerDoctrineTypeMapping('enum', 'string');
-		
-		$this->d3AddLongdescMultilangColumnsToOxmanufacturers($schema);
-	}
 
-    public function down(Schema $schema) : void
+    public function up(Schema $schema): void
-    {}
+    {
-	
+        $this->connection->getDatabasePlatform()->registerDoctrineTypeMapping('enum', 'string');
-	/**
+
-	 * @param Schema $schema
+        $this->d3AddLongdescMultilangColumnsToOxmanufacturers($schema);
-	 * @return void
+    }
-	 * @throws \Doctrine\DBAL\Schema\SchemaException
+
-	 */
+    public function down(Schema $schema): void
-	public function d3AddLongdescMultilangColumnsToOxmanufacturers(Schema $schema){
+    {
-		$table = !$schema->hasTable('oxmanufacturers') ?
+    }
-			$schema->createTable('oxmanufacturers') :
+
-			$schema->getTable('oxmanufacturers');
+    /**
-		
+     * @param Schema $schema
-		// lang 1
+     * @return void
-		if (!$table->hasColumn('D3DESCRIPTION_1')) {
+     * @throws \Doctrine\DBAL\Schema\SchemaException
-			$table->addColumn('D3DESCRIPTION_1', (new TextType())->getName())
+     */
-				->setLength($this->connection->getDatabasePlatform()::LENGTH_LIMIT_TEXT)
+    public function d3AddLongdescMultilangColumnsToOxmanufacturers(Schema $schema)
-				->setNotnull(true);
+    {
-		}
+        $table = !$schema->hasTable('oxmanufacturers') ?
-		
+            $schema->createTable('oxmanufacturers') :
-		// lang 2
+            $schema->getTable('oxmanufacturers');
-		if (!$table->hasColumn('D3DESCRIPTION_2')) {
+
-			$table->addColumn('D3DESCRIPTION_2', (new TextType())->getName())
+        // lang 1
-				->setLength($this->connection->getDatabasePlatform()::LENGTH_LIMIT_TEXT)
+        if (!$table->hasColumn('D3DESCRIPTION_1')) {
-				->setNotnull(true);
+            $table->addColumn('D3DESCRIPTION_1', (new TextType())->getName())
-		}
+                ->setLength($this->connection->getDatabasePlatform()::LENGTH_LIMIT_TEXT)
-		
+                ->setNotnull(true);
-		// lang 3
+        }
-		if (!$table->hasColumn('D3DESCRIPTION_3')) {
+
-			$table->addColumn('D3DESCRIPTION_3', (new TextType())->getName())
+        // lang 2
-				->setLength($this->connection->getDatabasePlatform()::LENGTH_LIMIT_TEXT)
+        if (!$table->hasColumn('D3DESCRIPTION_2')) {
-				->setNotnull(true);
+            $table->addColumn('D3DESCRIPTION_2', (new TextType())->getName())
-		}
+                ->setLength($this->connection->getDatabasePlatform()::LENGTH_LIMIT_TEXT)
-	}
+                ->setNotnull(true);
+        }
+
+        // lang 3
+        if (!$table->hasColumn('D3DESCRIPTION_3')) {
+            $table->addColumn('D3DESCRIPTION_3', (new TextType())->getName())
+                ->setLength($this->connection->getDatabasePlatform()::LENGTH_LIMIT_TEXT)
+                ->setNotnull(true);
+        }
+    }
 }

views/smarty/admin/d3manufacturerlongdesc.tpl

@@ -25,7 +25,7 @@
     <input type="hidden" name="editlanguage" value="[{$editlanguage}]">
 </form>
 
-<form name="myedit" id="myedit" action="[{$oViewConf->getSelfLink()}]" method="post" onSubmit="copyLongDesc( 'oxmanufacturers__D3DESCRIPTION' );" style="padding: 0px;margin: 0px;height:0px;">
+<form name="myedit" id="myedit" action="[{$oViewConf->getSelfLink()}]" method="post" onSubmit="copyLongDesc( 'oxmanufacturers__d3description' );" style="padding: 0px;margin: 0px;height:0px;">
     [{$oViewConf->getHiddenSid()}]
     <input type="hidden" name="cl" value="d3manufacturerinfolongdesc">
     <input type="hidden" name="fnc" value="">
@@ -33,9 +33,11 @@
     <input type="hidden" name="voxid" value="[{$oxid}]">
     <input type="hidden" name="editval[oxmanufacturers__oxid]" value="[{$oxid}]">
     <input type="hidden" name="catlang" value="[{$catlang}]">
-    <input type="hidden" name="editval[oxmanufacturers__D3DESCRIPTION]" value="">
+    <input type="hidden" name="editval[oxmanufacturers__d3description]" value="">
 
-    [{include file="include/category_text_editor.tpl"}]
+    <div style="margin-bottom: 40px">
+        [{include file="include/category_text_editor.tpl"}]
+    </div>
 </form>
 
 [{include file="bottomnaviitem.tpl"}]

views/twig/admin/d3manufacturerlongdesc.html.twig

@@ -23,7 +23,7 @@
     <input type="hidden" name="editlanguage" value="{{ editlanguage }}">
 </form>
 
-<form name="myedit" id="myedit" action="{{ oViewConf.getSelfLink() }}" method="post" onSubmit="copyLongDesc( 'oxmanufacturers__D3DESCRIPTION' );" style="padding: 0px;margin: 0px;height:0px;">
+<form name="myedit" id="myedit" action="{{ oViewConf.getSelfLink() }}" method="post" onSubmit="copyLongDesc( 'oxmanufacturers__d3description' );" style="padding: 0px;margin: 0px;height:0px;">
     {{ oViewConf.getHiddenSid()|raw }}
     <input type="hidden" name="cl" value="d3manufacturerinfolongdesc">
     <input type="hidden" name="fnc" value="">
@@ -31,7 +31,7 @@
     <input type="hidden" name="voxid" value="{{ oxid }}">
     <input type="hidden" name="editval[oxmanufacturers__oxid]" value="{{ oxid }}">
     <input type="hidden" name="catlang" value="{{ catlang }}">
-    <input type="hidden" name="editval[oxmanufacturers__D3DESCRIPTION]" value="">
+    <input type="hidden" name="editval[oxmanufacturers__d3description]" value="">
 
     {% include "include/category_text_editor.html.twig" %}
 </form>

views/twig/extensions/themes/default/page/details/inc/productmain.html.twig

@@ -0,0 +1,14 @@
+{% extends "page/details/inc/productmain.html.twig" %}
+
+{% block details_productmain_manufacturersicon %}
+    {% if oManufacturer.oxmanufacturers__oxicon.value %}
+        {{ parent() }}
+    {% else %}
+        <div class="action-links text-left">
+            <a href="{{ oManufacturer.getLink() }}" title="{{ oManufacturer.oxmanufacturers__oxtitle.value }}">
+                {{ translate({ ident: "MANUFACTURER", suffix: "COLON" }) }} {{ oManufacturer.oxmanufacturers__oxtitle.value }}
+            </a>
+            <span itemprop="brand" class="hidden">{{ oManufacturer.oxmanufacturers__oxtitle.value }}</span>
+        </div>
+    {% endif %}
+{% endblock %}

views/twig/extensions/themes/default/page/details/inc/tabs.html.twig

@@ -0,0 +1,20 @@
+{% extends "page/details/inc/tabs.html.twig" %}
+
+{% block details_tabs_invite %}
+    {{ parent() }}
+
+    {% set oConfig = oViewConf.getConfig() %}
+    {% set oManufacturer = oView.getManufacturer() %}
+    {% set sShopURL = oConfig.getConfigParam('sShopURL') %}
+    {% set description = oManufacturer.d3GetLongdesc() %}
+
+    {% if oManufacturer and oConfig.getConfigParam('d3manufacturerinformation_showManufacturertextOnDetailsPage') and description.rawValue|striptags|trim %}
+        {% capture append = "tabs" %}<a href="#manufacturertab" data-toggle="tab">{{ translate({ ident: "MANUFACTURER" }) }}</a>{% endcapture %}
+        {% capture append = "tabsContent" %}
+            <div id="manufacturertab" class="tab-pane{% if blFirstTab %} active{% endif %}">
+                {{ include(template_from_string(description)) }}
+            </div>
+            {% set blFirstTab = false %}
+        {% endcapture %}
+    {% endif %}
+{% endblock %}