From 58e9079a8239aa9b5dfc347d68ceba6abbf2c118 Mon Sep 17 00:00:00 2001 From: Daniel Seifert Date: Fri, 23 May 2025 14:14:43 +0200 Subject: [PATCH] don't call method from template to show messages in error case --- .../d3_overview_controller_pdfdocuments.php | 13 ++++++++++--- views/smarty/admin/orderoverview_pdfform.tpl | 9 +++++---- views/twig/admin/orderoverview_pdfform.html.twig | 9 +++++---- 3 files changed, 20 insertions(+), 11 deletions(-) diff --git a/Modules/Application/Controller/d3_overview_controller_pdfdocuments.php b/Modules/Application/Controller/d3_overview_controller_pdfdocuments.php index dff31ec..71d9a70 100644 --- a/Modules/Application/Controller/d3_overview_controller_pdfdocuments.php +++ b/Modules/Application/Controller/d3_overview_controller_pdfdocuments.php @@ -44,6 +44,8 @@ class d3_overview_controller_pdfdocuments extends d3_overview_controller_pdfdocu public function render() { + $this->addTplParam('d3PdfDocumentGeneratorList', $this->d3getGeneratorList()); + if ($this->doReload) { $formReload = << @@ -160,14 +162,19 @@ class d3_overview_controller_pdfdocuments extends d3_overview_controller_pdfdocu } /** - * @return registryOrderoverview * @throws ContainerExceptionInterface * @throws NotFoundExceptionInterface * @codeCoverageIgnore */ - public function d3getGeneratorList(): registryOrderoverview + public function d3getGeneratorList(): ?registryOrderoverview { - return ContainerFactory::getInstance()->getContainer()->get(registryOrderoverviewInterface::class); + try { + return ContainerFactory::getInstance()->getContainer()->get( registryOrderoverviewInterface::class ); + } catch (Exception $exception) { + Registry::getUtilsView()->addErrorToDisplay($exception->getMessage()); + } + + return null; } /** diff --git a/views/smarty/admin/orderoverview_pdfform.tpl b/views/smarty/admin/orderoverview_pdfform.tpl index 540bdb8..051b378 100644 --- a/views/smarty/admin/orderoverview_pdfform.tpl +++ b/views/smarty/admin/orderoverview_pdfform.tpl @@ -19,10 +19,11 @@ :  diff --git a/views/twig/admin/orderoverview_pdfform.html.twig b/views/twig/admin/orderoverview_pdfform.html.twig index d413d7a..743e31b 100644 --- a/views/twig/admin/orderoverview_pdfform.html.twig +++ b/views/twig/admin/orderoverview_pdfform.html.twig @@ -19,10 +19,11 @@ :