add test for backend login controller

2019-08-07 23:51:48 +02:00 · 2019-08-07 23:51:48 +02:00 · ed9c6dabb5
commit ed9c6dabb5
parent 27eaf777a5
2 changed files with 660 additions and 10 deletions
--- a/src/Modules/Application/Controller/Admin/d3_totp_LoginController.php
+++ b/src/Modules/Application/Controller/Admin/d3_totp_LoginController.php
@ -22,6 +22,8 @@ use Doctrine\DBAL\DBALException;
 use OxidEsales\Eshop\Application\Model\User;
 use OxidEsales\Eshop\Core\Exception\DatabaseConnectionException;
 use OxidEsales\Eshop\Core\Registry;
+use OxidEsales\Eshop\Core\Session;
+use OxidEsales\Eshop\Core\UtilsView;

 class d3_totp_LoginController extends d3_totp_LoginController_parent
 {
@ -32,25 +34,57 @@ class d3_totp_LoginController extends d3_totp_LoginController_parent
     */
    public function render()
    {
-        $auth = Registry::getSession()->getVariable("auth");
+        $auth = $this->d3GetSession()->getVariable("auth");

        $return = parent::render();

-        $totp = oxNew(d3totp::class);
+        $totp = $this->d3GetTotpObject();
        $totp->loadByUserId($auth);

        if ($auth
            && $totp->isActive()
-            && false == Registry::getSession()->getVariable(d3totp::TOTP_SESSION_VARNAME)
+            && false == $this->d3GetSession()->getVariable(d3totp::TOTP_SESSION_VARNAME)
        ) {
            // set auth as secured parameter;
-            Registry::getSession()->setVariable("auth", $auth);
+            $this->d3GetSession()->setVariable("auth", $auth);
            $this->addTplParam('request_totp', true);
        }

        return $return;
    }

+    /**
+     * @return d3totp
+     */
+    public function d3GetTotpObject()
+    {
+        return oxNew(d3totp::class);
+    }
+
+    /**
+     * @return d3backupcodelist
+     */
+    public function d3GetBackupCodeListObject()
+    {
+        return oxNew(d3backupcodelist::class);
+    }
+
+    /**
+     * @return UtilsView
+     */
+    public function d3GetUtilsView()
+    {
+        return Registry::getUtilsView();
+    }
+
+    /**
+     * @return Session
+     */
+    public function d3GetSession()
+    {
+        return Registry::getSession();
+    }
+
    /**
     * @return mixed|string
     * @throws DBALException
@ -60,7 +94,7 @@ class d3_totp_LoginController extends d3_totp_LoginController_parent
    {
        $sTotp = Registry::getRequest()->getRequestEscapedParameter('d3totp', true);

-        $totp = oxNew(d3totp::class);
+        $totp = $this->d3GetTotpObject();
        $totp->loadByUserId(Registry::getSession()->getVariable("auth"));

        $return = 'login';
@ -69,11 +103,11 @@ class d3_totp_LoginController extends d3_totp_LoginController_parent
            if ($this->isNoTotpOrNoLogin($totp)) {
                $return = parent::checklogin();
            } elseif ($this->hasValidTotp($sTotp, $totp)) {
-                Registry::getSession()->setVariable(d3totp::TOTP_SESSION_VARNAME, $sTotp);
+                $this->d3GetSession()->setVariable(d3totp::TOTP_SESSION_VARNAME, $sTotp);
                $return = "admin_start";
            }
        } catch (d3totp_wrongOtpException $oEx) {
-            Registry::getUtilsView()->addErrorToDisplay($oEx);
+            $this->d3GetUtilsView()->addErrorToDisplay($oEx);
        }

        return $return;
@ -85,7 +119,7 @@ class d3_totp_LoginController extends d3_totp_LoginController_parent
     */
    public function getBackupCodeCountMessage()
    {
-        $oBackupCodeList = oxNew(d3backupcodelist::class);
+        $oBackupCodeList = $this->d3GetBackupCodeListObject();
        $iCount = $oBackupCodeList->getAvailableCodeCount(Registry::getSession()->getVariable("auth"));

        if ($iCount < 4) {
@ -104,7 +138,7 @@ class d3_totp_LoginController extends d3_totp_LoginController_parent
     */
    public function isNoTotpOrNoLogin($totp)
    {
-        return false == Registry::getSession()->getVariable("auth")
+        return false == $this->d3GetSession()->getVariable("auth")
        || false == $totp->isActive();
    }

@ -125,7 +159,15 @@ class d3_totp_LoginController extends d3_totp_LoginController_parent

    public function d3CancelLogin()
    {
-        $oUser = oxNew(User::class);
+        $oUser = $this->d3GetUserObject();
        $oUser->logout();
    }
+
+    /**
+     * @return User
+     */
+    public function d3GetUserObject()
+    {
+        return oxNew(User::class);
+    }
 }
--- a/src/tests/unit/Modules/Application/Controller/Admin/d3_totp_LoginControllerTest.php
+++ b/src/tests/unit/Modules/Application/Controller/Admin/d3_totp_LoginControllerTest.php
@ -0,0 +1,608 @@
+<?php
+
+/**
+ * This Software is the property of Data Development and is protected
+ * by copyright law - it is NOT Freeware.
+ *
+ * Any unauthorized use of this software without a valid license
+ * is a violation of the license agreement and will be prosecuted by
+ * civil and criminal law.
+ *
+ * http://www.shopmodule.com
+ *
+ * @copyright (C) D3 Data Development (Inh. Thomas Dartsch)
+ * @author    D3 Data Development - Daniel Seifert <support@shopmodule.com>
+ * @link      http://www.oxidmodule.com
+ */
+
+namespace D3\Totp\tests\unit\Modules\Application\Controller\Admin;
+
+use D3\Totp\Application\Model\d3backupcodelist;
+use D3\Totp\Application\Model\d3totp;
+use D3\Totp\Application\Model\Exceptions\d3totp_wrongOtpException;
+use D3\Totp\Modules\Application\Controller\Admin\d3_totp_LoginController;
+use D3\Totp\tests\unit\d3TotpUnitTestCase;
+use OxidEsales\Eshop\Application\Model\User;
+use OxidEsales\Eshop\Core\Registry;
+use OxidEsales\Eshop\Core\Session;
+use OxidEsales\Eshop\Core\UtilsView;
+use PHPUnit_Framework_MockObject_MockObject;
+use ReflectionException;
+
+class d3_totp_LoginControllerTest extends d3TotpUnitTestCase
+{
+    /** @var d3_totp_LoginController */
+    protected $_oController;
+
+    /**
+     * setup basic requirements
+     */
+    public function setUp()
+    {
+        parent::setUp();
+
+        $this->_oController = oxNew(d3_totp_LoginController::class);
+    }
+
+    public function tearDown()
+    {
+        parent::tearDown();
+
+        unset($this->_oController);
+    }
+
+    /**
+     * @test
+     * @throws ReflectionException
+     */
+    public function canRenderNoAuth()
+    {
+        /** @var d3totp|PHPUnit_Framework_MockObject_MockObject $oTotpMock */
+        $oTotpMock = $this->getMock(d3totp::class, array(
+            'isActive',
+            'loadByUserId'
+        ));
+        $oTotpMock->expects($this->never())->method('isActive')->willReturn(false);
+        $oTotpMock->method('loadByUserId')->willReturn(true);
+
+        /** @var Session|PHPUnit_Framework_MockObject_MockObject $oSessionMock */
+        $oSessionMock = $this->getMock(Session::class, array(
+            'getVariable',
+            'setVariable',
+        ));
+        $oSessionMock->method('getVariable')->will($this->onConsecutiveCalls(false, true));
+        $oSessionMock->expects($this->never())->method('setVariable')->willReturn(false);
+
+        /** @var d3_totp_LoginController|PHPUnit_Framework_MockObject_MockObject $oControllerMock */
+        $oControllerMock = $this->getMock(d3_totp_LoginController::class, array(
+            'd3GetSession',
+            'd3GetTotpObject'
+        ));
+        $oControllerMock->method('d3GetSession')->willReturn($oSessionMock);
+        $oControllerMock->method('d3GetTotpObject')->willReturn($oTotpMock);
+
+        $this->_oController = $oControllerMock;
+
+        $this->assertSame('login.tpl', $this->callMethod($this->_oController, 'render'));
+        $this->assertNotTrue($this->callMethod($this->_oController, 'getViewDataElement', array('request_totp')));
+    }
+
+    /**
+     * @test
+     * @throws ReflectionException
+     */
+    public function canRenderTotpNotActive()
+    {
+        /** @var d3totp|PHPUnit_Framework_MockObject_MockObject $oTotpMock */
+        $oTotpMock = $this->getMock(d3totp::class, array(
+            'isActive',
+            'loadByUserId'
+        ));
+        $oTotpMock->expects($this->once())->method('isActive')->willReturn(false);
+        $oTotpMock->method('loadByUserId')->willReturn(true);
+
+        /** @var Session|PHPUnit_Framework_MockObject_MockObject $oSessionMock */
+        $oSessionMock = $this->getMock(Session::class, array(
+            'getVariable',
+            'setVariable',
+        ));
+        $oSessionMock->method('getVariable')->will($this->onConsecutiveCalls(true, true));
+        $oSessionMock->expects($this->never())->method('setVariable')->willReturn(false);
+
+        /** @var d3_totp_LoginController|PHPUnit_Framework_MockObject_MockObject $oControllerMock */
+        $oControllerMock = $this->getMock(d3_totp_LoginController::class, array(
+            'd3GetSession',
+            'd3GetTotpObject'
+        ));
+        $oControllerMock->method('d3GetSession')->willReturn($oSessionMock);
+        $oControllerMock->method('d3GetTotpObject')->willReturn($oTotpMock);
+
+        $this->_oController = $oControllerMock;
+
+        $this->assertSame('login.tpl', $this->callMethod($this->_oController, 'render'));
+        $this->assertNotTrue($this->callMethod($this->_oController, 'getViewDataElement', array('request_totp')));
+    }
+
+    /**
+     * @test
+     * @throws ReflectionException
+     */
+    public function canRenderInTotpLoginProcess()
+    {
+        /** @var d3totp|PHPUnit_Framework_MockObject_MockObject $oTotpMock */
+        $oTotpMock = $this->getMock(d3totp::class, array(
+            'isActive',
+            'loadByUserId'
+        ));
+        $oTotpMock->expects($this->once())->method('isActive')->willReturn(false);
+        $oTotpMock->method('loadByUserId')->willReturn(true);
+
+        /** @var Session|PHPUnit_Framework_MockObject_MockObject $oSessionMock */
+        $oSessionMock = $this->getMock(Session::class, array(
+            'getVariable',
+            'setVariable',
+        ));
+        $oSessionMock->method('getVariable')->will($this->onConsecutiveCalls(true, true));
+        $oSessionMock->expects($this->never())->method('setVariable')->willReturn(false);
+
+        /** @var d3_totp_LoginController|PHPUnit_Framework_MockObject_MockObject $oControllerMock */
+        $oControllerMock = $this->getMock(d3_totp_LoginController::class, array(
+            'd3GetSession',
+            'd3GetTotpObject'
+        ));
+        $oControllerMock->method('d3GetSession')->willReturn($oSessionMock);
+        $oControllerMock->method('d3GetTotpObject')->willReturn($oTotpMock);
+
+        $this->_oController = $oControllerMock;
+
+        $this->assertSame('login.tpl', $this->callMethod($this->_oController, 'render'));
+        $this->assertNotTrue($this->callMethod($this->_oController, 'getViewDataElement', array('request_totp')));
+    }
+
+    /**
+     * @test
+     * @throws ReflectionException
+     */
+    public function canRenderRequestTotp()
+    {
+        /** @var d3totp|PHPUnit_Framework_MockObject_MockObject $oTotpMock */
+        $oTotpMock = $this->getMock(d3totp::class, array(
+            'isActive',
+            'loadByUserId'
+        ));
+        $oTotpMock->expects($this->once())->method('isActive')->willReturn(true);
+        $oTotpMock->method('loadByUserId')->willReturn(true);
+
+        /** @var Session|PHPUnit_Framework_MockObject_MockObject $oSessionMock */
+        $oSessionMock = $this->getMock(Session::class, array(
+            'getVariable',
+            'setVariable',
+        ));
+        $oSessionMock->method('getVariable')->will($this->onConsecutiveCalls(true, false));
+        $oSessionMock->expects($this->once())->method('setVariable')->willReturn(false);
+
+        /** @var d3_totp_LoginController|PHPUnit_Framework_MockObject_MockObject $oControllerMock */
+        $oControllerMock = $this->getMock(d3_totp_LoginController::class, array(
+            'd3GetSession',
+            'd3GetTotpObject'
+        ));
+        $oControllerMock->method('d3GetSession')->willReturn($oSessionMock);
+        $oControllerMock->method('d3GetTotpObject')->willReturn($oTotpMock);
+
+        $this->_oController = $oControllerMock;
+
+        $this->assertSame('login.tpl', $this->callMethod($this->_oController, 'render'));
+        $this->assertTrue($this->callMethod($this->_oController, 'getViewDataElement', array('request_totp')));
+    }
+
+    /**
+     * @test
+     * @throws ReflectionException
+     */
+    public function d3GetTotpObjectReturnsRightObject()
+    {
+        $this->assertInstanceOf(
+            d3totp::class,
+            $this->callMethod($this->_oController, 'd3GetTotpObject')
+        );
+    }
+
+    /**
+     * @test
+     * @throws ReflectionException
+     */
+    public function d3GetBackupCodeListObjectReturnsRightObject()
+    {
+        $this->assertInstanceOf(
+            d3backupcodelist::class,
+            $this->callMethod($this->_oController, 'd3GetBackupCodeListObject')
+        );
+    }
+
+    /**
+     * @test
+     * @throws ReflectionException
+     */
+    public function d3GetUtilsViewReturnsRightObject()
+    {
+        $this->assertInstanceOf(
+            UtilsView::class,
+            $this->callMethod($this->_oController, 'd3GetUtilsView')
+        );
+    }
+
+    /**
+     * @test
+     * @throws ReflectionException
+     */
+    public function d3GetSessionReturnsRightObject()
+    {
+        $this->assertInstanceOf(
+            Session::class,
+            $this->callMethod($this->_oController, 'd3GetSession')
+        );
+    }
+
+    /**
+     * @test
+     * @throws ReflectionException
+     */
+    public function checkloginNoTotp()
+    {
+        /** @var d3totp|PHPUnit_Framework_MockObject_MockObject $oTotpMock */
+        $oTotpMock = $this->getMock(d3totp::class, array(
+            'loadByUserId'
+        ));
+        $oTotpMock->method('loadByUserId')->willReturn(true);
+
+        /** @var d3_totp_LoginController|PHPUnit_Framework_MockObject_MockObject $oControllerMock */
+        $oControllerMock = $this->getMock(d3_totp_LoginController::class, array(
+            'd3GetTotpObject',
+            'isNoTotpOrNoLogin',
+            'hasValidTotp',
+        ));
+        $oControllerMock->method('d3GetTotpObject')->willReturn($oTotpMock);
+        $oControllerMock->method('isNoTotpOrNoLogin')->willReturn(true);
+        $oControllerMock->method('hasValidTotp')->willReturn(false);
+
+        $this->_oController = $oControllerMock;
+
+        $this->assertEmpty($this->callMethod($this->_oController, 'checklogin'));
+    }
+
+    /**
+     * @test
+     * @throws ReflectionException
+     */
+    public function checkloginUnvalidTotp()
+    {
+        /** @var UtilsView|PHPUnit_Framework_MockObject_MockObject $utilsViewMock */
+        $utilsViewMock = $this->getMock(UtilsView::class, array(
+            'addErrorToDisplay',
+        ));
+        $utilsViewMock->expects($oSpy = $this->once())->method('addErrorToDisplay')->willReturn(true);
+        
+        /** @var d3totp|PHPUnit_Framework_MockObject_MockObject $oTotpMock */
+        $oTotpMock = $this->getMock(d3totp::class, array(
+            'loadByUserId'
+        ));
+        $oTotpMock->method('loadByUserId')->willReturn(true);
+
+        /** @var d3_totp_LoginController|PHPUnit_Framework_MockObject_MockObject $oControllerMock */
+        $oControllerMock = $this->getMock(d3_totp_LoginController::class, array(
+            'd3GetTotpObject',
+            'isNoTotpOrNoLogin',
+            'hasValidTotp',
+            'd3GetUtilsView',
+        ));
+        $oControllerMock->method('d3GetTotpObject')->willReturn($oTotpMock);
+        $oControllerMock->method('isNoTotpOrNoLogin')->willReturn(false);
+        $oControllerMock->method('hasValidTotp')->willThrowException(oxNew(d3totp_wrongOtpException::class));
+        $oControllerMock->method('d3GetUtilsView')->willReturn($utilsViewMock);
+
+        $this->_oController = $oControllerMock;
+
+        $this->assertSame('login', $this->callMethod($this->_oController, 'checklogin'));
+    }
+
+    /**
+     * @test
+     * @throws ReflectionException
+     */
+    public function checkloginValidTotp()
+    {
+        /** @var UtilsView|PHPUnit_Framework_MockObject_MockObject $utilsViewMock */
+        $utilsViewMock = $this->getMock(UtilsView::class, array(
+            'addErrorToDisplay',
+        ));
+        $utilsViewMock->expects($this->never())->method('addErrorToDisplay')->willReturn(true);
+
+        /** @var d3totp|PHPUnit_Framework_MockObject_MockObject $oTotpMock */
+        $oTotpMock = $this->getMock(d3totp::class, array(
+            'loadByUserId'
+        ));
+        $oTotpMock->method('loadByUserId')->willReturn(true);
+
+        /** @var Session|PHPUnit_Framework_MockObject_MockObject $oSessionMock */
+        $oSessionMock = $this->getMock(Session::class, array(
+            'setVariable',
+        ));
+        $oSessionMock->expects($this->once())->method('setVariable')->willReturn(false);
+
+        /** @var d3_totp_LoginController|PHPUnit_Framework_MockObject_MockObject $oControllerMock */
+        $oControllerMock = $this->getMock(d3_totp_LoginController::class, array(
+            'd3GetTotpObject',
+            'isNoTotpOrNoLogin',
+            'hasValidTotp',
+            'd3GetUtilsView',
+            'd3GetSession',
+        ));
+        $oControllerMock->method('d3GetTotpObject')->willReturn($oTotpMock);
+        $oControllerMock->method('isNoTotpOrNoLogin')->willReturn(false);
+        $oControllerMock->method('hasValidTotp')->willReturn(true);
+        $oControllerMock->method('d3GetUtilsView')->willReturn($utilsViewMock);
+        $oControllerMock->method('d3GetSession')->willReturn($oSessionMock);
+
+        $this->_oController = $oControllerMock;
+
+        $this->assertSame('admin_start', $this->callMethod($this->_oController, 'checklogin'));
+    }
+
+    /**
+     * @test
+     * @throws ReflectionException
+     */
+    public function getBackupCodeCountMessageShowMessage()
+    {
+        /** @var d3backupcodelist|PHPUnit_Framework_MockObject_MockObject $oBackupCodeListMock */
+        $oBackupCodeListMock = $this->getMock(d3backupcodelist::class, array(
+            'getAvailableCodeCount',
+        ));
+        $oBackupCodeListMock->method('getAvailableCodeCount')->willReturn(2);
+        
+        /** @var d3_totp_LoginController|PHPUnit_Framework_MockObject_MockObject $oControllerMock */
+        $oControllerMock = $this->getMock(d3_totp_LoginController::class, array(
+            'd3GetBackupCodeListObject',
+        ));
+        $oControllerMock->method('d3GetBackupCodeListObject')->willReturn($oBackupCodeListMock);
+
+        $this->_oController = $oControllerMock;
+
+        $this->assertGreaterThan(
+            0,
+            strpos(
+                $this->callMethod($this->_oController, 'getBackupCodeCountMessage'),
+                ' 2 '
+            )
+        );
+    }
+
+    /**
+     * @test
+     * @throws ReflectionException
+     */
+    public function getBackupCodeCountMessageDontShowMessage()
+    {
+        /** @var d3backupcodelist|PHPUnit_Framework_MockObject_MockObject $oBackupCodeListMock */
+        $oBackupCodeListMock = $this->getMock(d3backupcodelist::class, array(
+            'getAvailableCodeCount',
+        ));
+        $oBackupCodeListMock->method('getAvailableCodeCount')->willReturn(10);
+
+        /** @var d3_totp_LoginController|PHPUnit_Framework_MockObject_MockObject $oControllerMock */
+        $oControllerMock = $this->getMock(d3_totp_LoginController::class, array(
+            'd3GetBackupCodeListObject',
+        ));
+        $oControllerMock->method('d3GetBackupCodeListObject')->willReturn($oBackupCodeListMock);
+
+        $this->_oController = $oControllerMock;
+
+        $this->assertEmpty(
+            $this->callMethod($this->_oController, 'getBackupCodeCountMessage')
+        );
+    }
+
+    /**
+     * @test
+     * @throws ReflectionException
+     */
+    public function isNoTotpOrNoLoginIsAuth()
+    {
+        /** @var d3totp|PHPUnit_Framework_MockObject_MockObject $oTotpMock */
+        $oTotpMock = $this->getMock(d3totp::class, array(
+            'isActive'
+        ));
+        $oTotpMock->method('isActive')->willReturn(true);
+
+        /** @var Session|PHPUnit_Framework_MockObject_MockObject $oSessionMock */
+        $oSessionMock = $this->getMock(Session::class, array(
+            'getVariable',
+        ));
+        $oSessionMock->method('getVariable')->willReturn(true);
+
+        /** @var d3_totp_LoginController|PHPUnit_Framework_MockObject_MockObject $oControllerMock */
+        $oControllerMock = $this->getMock(d3_totp_LoginController::class, array(
+            'd3GetSession',
+        ));
+        $oControllerMock->method('d3GetSession')->willReturn($oSessionMock);
+
+        $this->_oController = $oControllerMock;
+
+        $this->assertFalse(
+            $this->callMethod($this->_oController, 'isNoTotpOrNoLogin', array($oTotpMock))
+        );
+    }
+
+    /**
+     * @test
+     * @throws ReflectionException
+     */
+    public function isNoTotpOrNoLoginTotpNotActive()
+    {
+        /** @var d3totp|PHPUnit_Framework_MockObject_MockObject $oTotpMock */
+        $oTotpMock = $this->getMock(d3totp::class, array(
+            'isActive'
+        ));
+        $oTotpMock->method('isActive')->willReturn(true);
+
+        /** @var Session|PHPUnit_Framework_MockObject_MockObject $oSessionMock */
+        $oSessionMock = $this->getMock(Session::class, array(
+            'getVariable',
+        ));
+        $oSessionMock->method('getVariable')->willReturn(true);
+
+        /** @var d3_totp_LoginController|PHPUnit_Framework_MockObject_MockObject $oControllerMock */
+        $oControllerMock = $this->getMock(d3_totp_LoginController::class, array(
+            'd3GetSession',
+        ));
+        $oControllerMock->method('d3GetSession')->willReturn($oSessionMock);
+
+        $this->_oController = $oControllerMock;
+
+        $this->assertFalse(
+            $this->callMethod($this->_oController, 'isNoTotpOrNoLogin', array($oTotpMock))
+        );
+    }
+
+    /**
+     * @test
+     * @throws ReflectionException
+     */
+    public function isNoTotpOrNoLoginPass()
+    {
+        /** @var d3totp|PHPUnit_Framework_MockObject_MockObject $oTotpMock */
+        $oTotpMock = $this->getMock(d3totp::class, array(
+            'isActive'
+        ));
+        $oTotpMock->method('isActive')->willReturn(false);
+
+        /** @var Session|PHPUnit_Framework_MockObject_MockObject $oSessionMock */
+        $oSessionMock = $this->getMock(Session::class, array(
+            'getVariable',
+        ));
+        $oSessionMock->method('getVariable')->willReturn(false);
+
+        /** @var d3_totp_LoginController|PHPUnit_Framework_MockObject_MockObject $oControllerMock */
+        $oControllerMock = $this->getMock(d3_totp_LoginController::class, array(
+            'd3GetSession',
+        ));
+        $oControllerMock->method('d3GetSession')->willReturn($oSessionMock);
+
+        $this->_oController = $oControllerMock;
+
+        $this->assertTrue(
+            $this->callMethod($this->_oController, 'isNoTotpOrNoLogin', array($oTotpMock))
+        );
+    }
+
+    /**
+     * @test
+     * @throws ReflectionException
+     */
+    public function hasValidTotpTrueSessionVarname()
+    {
+        Registry::getSession()->setVariable(d3totp::TOTP_SESSION_VARNAME, true);
+
+        /** @var d3totp|PHPUnit_Framework_MockObject_MockObject $oTotpMock */
+        $oTotpMock = $this->getMock(d3totp::class, array(
+            'verify',
+        ));
+        $oTotpMock->method('verify')->willReturn(false);
+
+        $this->assertTrue(
+            $this->callMethod($this->_oController, 'hasValidTotp', array('123456', $oTotpMock))
+        );
+    }
+
+    /**
+     * @test
+     * @throws ReflectionException
+     */
+    public function hasValidTotpTrueValidTotp()
+    {
+        Registry::getSession()->setVariable(d3totp::TOTP_SESSION_VARNAME, false);
+
+        /** @var d3totp|PHPUnit_Framework_MockObject_MockObject $oTotpMock */
+        $oTotpMock = $this->getMock(d3totp::class, array(
+            'verify',
+        ));
+        $oTotpMock->method('verify')->willReturn(true);
+
+        $this->assertTrue(
+            $this->callMethod($this->_oController, 'hasValidTotp', array('123456', $oTotpMock))
+        );
+    }
+
+    /**
+     * @test
+     * @throws ReflectionException
+     */
+    public function hasValidTotpFalseMissingTotp()
+    {
+        Registry::getSession()->setVariable(d3totp::TOTP_SESSION_VARNAME, false);
+
+        /** @var d3totp|PHPUnit_Framework_MockObject_MockObject $oTotpMock */
+        $oTotpMock = $this->getMock(d3totp::class, array(
+            'verify',
+        ));
+        $oTotpMock->method('verify')->willReturn(true);
+
+        $this->assertFalse(
+            $this->callMethod($this->_oController, 'hasValidTotp', array(null, $oTotpMock))
+        );
+    }
+
+    /**
+     * @test
+     * @throws ReflectionException
+     */
+    public function hasValidTotpFalseUnverifiedTotp()
+    {
+        Registry::getSession()->setVariable(d3totp::TOTP_SESSION_VARNAME, false);
+
+        /** @var d3totp|PHPUnit_Framework_MockObject_MockObject $oTotpMock */
+        $oTotpMock = $this->getMock(d3totp::class, array(
+            'verify',
+        ));
+        $oTotpMock->method('verify')->willReturn(false);
+
+        $this->assertFalse(
+            $this->callMethod($this->_oController, 'hasValidTotp', array('123456', $oTotpMock))
+        );
+    }
+
+    /**
+     * @test
+     * @throws ReflectionException
+     */
+    public function d3CancelLoginPass()
+    {
+        /** @var User|PHPUnit_Framework_MockObject_MockObject $oUserMock */
+        $oUserMock = $this->getMock(User::class, array(
+            'logout',
+        ));
+        $oUserMock->expects($this->once())->method('logout')->willReturn(true);
+        
+        /** @var d3_totp_LoginController|PHPUnit_Framework_MockObject_MockObject $oControllerMock */
+        $oControllerMock = $this->getMock(d3_totp_LoginController::class, array(
+            'd3GetUserObject',
+        ));
+        $oControllerMock->method('d3GetUserObject')->willReturn($oUserMock);
+
+        $this->_oController = $oControllerMock;
+        
+        $this->callMethod($this->_oController, 'd3CancelLogin');
+    }
+
+    /**
+     * @test
+     * @throws ReflectionException
+     */
+    public function d3GetUserObjectReturnsRightObject()
+    {
+        $this->assertInstanceOf(
+            User::class,
+            $this->callMethod($this->_oController, 'd3GetUserObject')
+        );
+    }
+}