D3Public/pdfdokumente
8
0
Fork 0
Code Pull Requests Releases Activity

don't call method from template to show messages in error case

Browse Source
This commit is contained in:
Daniel Seifert
2025-05-23 14:14:43 +02:00
parent 4f4776e3a2
commit 58e9079a82
3 changed files with 20 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
Modules/Application/Controller/d3_overview_controller_pdfdocuments.php
View File

@ -44,6 +44,8 @@ class d3_overview_controller_pdfdocuments extends d3_overview_controller_pdfdocu
public function render() public function render()
{ {
$this->addTplParam('d3PdfDocumentGeneratorList', $this->d3getGeneratorList());
if ($this->doReload) { if ($this->doReload) {
$formReload = <<<HTML $formReload = <<<HTML
<html lang="de"> <html lang="de">
@ -160,14 +162,19 @@ class d3_overview_controller_pdfdocuments extends d3_overview_controller_pdfdocu
} }
/** /**
* @return registryOrderoverview
* @throws ContainerExceptionInterface * @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface * @throws NotFoundExceptionInterface
* @codeCoverageIgnore * @codeCoverageIgnore
*/ */
public function d3getGeneratorList(): registryOrderoverview public function d3getGeneratorList(): ?registryOrderoverview
{ {
return ContainerFactory::getInstance()->getContainer()->get(registryOrderoverviewInterface::class); try {
return ContainerFactory::getInstance()->getContainer()->get( registryOrderoverviewInterface::class );
} catch (Exception $exception) {
Registry::getUtilsView()->addErrorToDisplay($exception->getMessage());
}
return null;
} }
/** /**

5
views/smarty/admin/orderoverview_pdfform.tpl
View File

@ -19,10 +19,11 @@
<label for="pdftype">[{oxmultilang ident="D3_PDFDOCUMENTS_PDF_TYPE" suffix="COLON"}]</label>:&nbsp; <label for="pdftype">[{oxmultilang ident="D3_PDFDOCUMENTS_PDF_TYPE" suffix="COLON"}]</label>:&nbsp;
<select id="pdftype" name="pdftype" class="editinput" style="min-width:150px;"> <select id="pdftype" name="pdftype" class="editinput" style="min-width:150px;">
[{block name="d3_pdfdocuments_order_overview_pdfTypeOptions"}] [{block name="d3_pdfdocuments_order_overview_pdfTypeOptions"}]
[{assign var="generatorList" value=$oView->d3getGeneratorList()}] [{if $d3PdfDocumentGeneratorList}]
[{foreach from=$generatorList->getList() item="generator"}] [{foreach from=$d3PdfDocumentGeneratorList->getList() item="generator"}]
<option value="[{$generator->getRequestId()}]">[{oxmultilang ident=$generator->getTitleIdent()}]</option> <option value="[{$generator->getRequestId()}]">[{oxmultilang ident=$generator->getTitleIdent()}]</option>
[{/foreach}] [{/foreach}]
[{/if}]
[{/block}] [{/block}]
</select> </select>
</td> </td>

5
views/twig/admin/orderoverview_pdfform.html.twig
View File

@ -19,10 +19,11 @@
<label for="pdftype">{{ translate({ ident: "D3_PDFDOCUMENTS_PDF_TYPE" }) }}</label>:&nbsp; <label for="pdftype">{{ translate({ ident: "D3_PDFDOCUMENTS_PDF_TYPE" }) }}</label>:&nbsp;
<select id="pdftype" name="pdftype" class="editinput" style="min-width:150px;"> <select id="pdftype" name="pdftype" class="editinput" style="min-width:150px;">
{% block d3_pdfdocuments_order_overview_pdfTypeOptions %} {% block d3_pdfdocuments_order_overview_pdfTypeOptions %}
{% set generatorList = oView.d3getGeneratorList() %} {% if d3PdfDocumentGeneratorList %}
{% for generator in generatorList.getList() %} {% for generator in d3PdfDocumentGeneratorList.getList() %}
<option value="{{ generator.getRequestId() }}">{{ translate({ ident: generator.getTitleIdent() }) }}</option> <option value="{{ generator.getRequestId() }}">{{ translate({ ident: generator.getTitleIdent() }) }}</option>
{% endfor %} {% endfor %}
{% endif %}
{% endblock %} {% endblock %}
</select> </select>
</td> </td>